- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Sep 5 2019
Oct 9 2018
Sep 29 2018
Is there a chance those aspects could be split out into separate patches?
Also still hoping for a variant of the bug fix patch which does not need a string freeze break, if possible.
Hi, René. Thanks for patch, but your new version also produce new problems :)
Sep 17 2018
Hi, Friedrich. Ok, we can skip the patch and wait for upstream KXmlGui fix. I should then abandon the revison?
Sep 15 2018
Sep 14 2018
- Drop last unrelated changes :)
- Drop another unrelated change
- Drop unrelated changes
New version works well - no segfaults, no memory leaks.
- More auto
- Drop QSharedPointer usage
Sep 12 2018
Hi, Friedrich. Simple detaching doesn't remove segfaults. Current version also keep segfaults :(
Right now I would favour your initial proposal.
- Address comments
Sep 11 2018
Thanks for your review. I think about ordering problem and found another interesting solution. We can use KXMLGUIClient::plugActionList() method to solve our case. We can implement common base class, for example ICodeAnalyzerPlugin, with appropriate methods which return file/project analyze actions and use them to (re)build sorted menus and plug them into our main menubar. Such approach can be also used for another plugins, like Heaptrack/Valgrind (run-time checkers/analyzers).
LGFM
Sep 10 2018
As an author of D14931 I need to apologize for passing this bug
- Return QSharedPointers back
- Delete views/models on output remove
- Patch code simplify
Sep 7 2018
ping ?
ping ?
Aug 31 2018
Aug 30 2018
Aug 29 2018
could we perhaps ensure a normalized order of the plugins in the plugin controller?
Aug 23 2018
Aug 22 2018
- Rebase to master (sorry for unnecessary steps)
- Rebase to 5.3
- Remove QPointer
Thank you all for the detailed code review. I just merge this patch to 5.3 branch.
- Inline comments fixes
Aug 21 2018
- Simplify code
- Enable sorting by default
ping
- Small codestyle fix
- Capitalization fix
Tooltips have no title-capitalization.
- Simplify code, rebase to master
- Add indication about Clazy run in background (related to bug 375557)
- Add indication about Clazy run in background (related to bug 375557)
- Inline comments and i18n fixes
- Problems deduplication
@arrowd, can you test the plugin on your FreeBSD system? My main question - is BSD make works well with our generated makefile.
Aug 20 2018
Note that, unless you pack clazy as well, the plugin will be unusable for AppImage/Windows.
- Test fixes
- More const
- Codestyle fixes
- Escape path spaces for correct make run
- i18n fixes
- Fix crash during error parsing
- Fix clazy "empty-qstringliteral" warning
- Add readme
FWIW: Okular uses the Discount library for reading markdown documents, showing them as HTML. Also Cantor will do so too: D14738: Add the markdown entry.
Maybe it'd be a good idea to use it -- there are few options:
- make the library a hard dependency for this plugin (which then would not be built if discount is not found
- optionally use discount, using this simple fallback otherwise (though with the risk of rotting)
- optionally use discount, and show no documentation if not found
Aug 17 2018
Aug 15 2018
Aug 14 2018
In D14288#299942, @kossebau wrote:Issues seen while testing:
Project config page:
- Initial page shows a commandline which does not reflect the state of the options (e.g. showing "-qt4-compat" while the respective "Qt4-compatible" button is off.
In D14288#301577, @kossebau wrote:Another issue I meanwhile hit:
Clazy analyzer is offered in the single file context menu also for header files (or also UI files). Trying to run it fails with
Nothing to check: /path/to/build/compile_commands.json contains no matching itemsNot sure if possible, but would be good to have the action item only added for files which are listed in the commands file.
And same for the entry in the Code main menu.
In D14391#298329, @kossebau wrote:Never noticed that randomness, but agree that is not perfect and should be fixed.
- Misprint fix
- JobParameters fixes
New version fixes: