Feed Advanced Search

Sun, Sep 1

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Fix unrelated change

Sun, Sep 1, 6:46 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Keep comment at the right place

Sun, Sep 1, 6:32 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Remove unneeded change

Sun, Sep 1, 6:16 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Remove trailing whitespaces

Sun, Sep 1, 6:12 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Some cleanup and add unittest

Sun, Sep 1, 5:44 PM · KDE Partition Manager
shubham closed D23572: Reduce temperature's precision from six decimal places to two.
Sun, Sep 1, 5:42 PM · KDE Partition Manager

Fri, Aug 30

shubham retitled D23572: Reduce temperature's precision from six decimal places to two from Reduce temperature's precision from six decimal places to one to Reduce temperature's precision from six decimal places to two.
Fri, Aug 30, 2:17 AM · KDE Partition Manager

Thu, Aug 29

stikonas accepted D23572: Reduce temperature's precision from six decimal places to two.
Thu, Aug 29, 7:53 PM · KDE Partition Manager
shubham updated the test plan for D23572: Reduce temperature's precision from six decimal places to two.
Thu, Aug 29, 7:17 PM · KDE Partition Manager
shubham added a project to D23572: Reduce temperature's precision from six decimal places to two: KDE Partition Manager.
Thu, Aug 29, 7:16 PM · KDE Partition Manager

Mon, Aug 26

shubham closed D22321: Add unit test for Polkit backend.
Mon, Aug 26, 8:11 AM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.
Mon, Aug 26, 8:00 AM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.

Rebase

Mon, Aug 26, 7:56 AM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.

Rebase wrt parent

Mon, Aug 26, 7:54 AM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

const at the end of startHelper() function

Mon, Aug 26, 7:49 AM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Use sync version for checking authorization

Mon, Aug 26, 7:36 AM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Remove left over commented code

Mon, Aug 26, 7:28 AM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Fix documentation

Mon, Aug 26, 7:26 AM · KDE Partition Manager
shubham reopened D22321: Add unit test for Polkit backend.
Mon, Aug 26, 7:23 AM · KDE Partition Manager
shubham reopened D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Mon, Aug 26, 7:22 AM · KDE Partition Manager
shubham closed D22321: Add unit test for Polkit backend.
Mon, Aug 26, 7:11 AM · KDE Partition Manager
shubham closed D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Mon, Aug 26, 7:11 AM · KDE Partition Manager

Sun, Aug 25

shubham updated the diff for D22321: Add unit test for Polkit backend.

More changes

Sun, Aug 25, 8:07 AM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.

Fix linker error

Sun, Aug 25, 8:06 AM · KDE Partition Manager

Sat, Aug 24

shubham abandoned D21617: Handle action authorization inside helper.
Sat, Aug 24, 3:00 PM · KDE Partition Manager

Fri, Aug 23

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Remove unused parameters

Fri, Aug 23, 6:03 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Success starting the kauth_externalcommand helper

Fri, Aug 23, 2:13 PM · KDE Partition Manager

Thu, Aug 22

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Remove commented code

Thu, Aug 22, 7:10 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Refactor

Thu, Aug 22, 7:01 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
  1. Use checkAuthorizationSync() to authenticate
  2. Fix infinite recursion in startHelper()
Thu, Aug 22, 6:57 PM · KDE Partition Manager
stikonas requested changes to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Thu, Aug 22, 6:47 PM · KDE Partition Manager

Mon, Aug 19

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Try to start the helper(Atleast polkit-qt-1)

Mon, Aug 19, 6:13 AM · KDE Partition Manager

Aug 18 2019

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Remove unnecessary linking

Aug 18 2019, 10:44 AM · KDE Partition Manager

Aug 16 2019

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
  1. Fix runtime warnings inside initPolkitAgent()
  2. Use "new" inside ctor to instantiate object
Aug 16 2019, 5:59 PM · KDE Partition Manager

Aug 14 2019

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Move helperMain() outside Q_SLOTS

Aug 14 2019, 6:19 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

some more changes

Aug 14 2019, 5:32 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Try fixing the inline comments

Aug 14 2019, 5:30 PM · KDE Partition Manager
shubham added inline comments to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 14 2019, 5:00 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 14 2019, 4:56 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Try to fix the broken things

Aug 14 2019, 4:07 PM · KDE Partition Manager

Aug 13 2019

stikonas added inline comments to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 13 2019, 11:15 PM · KDE Partition Manager
stikonas requested changes to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 13 2019, 11:13 PM · KDE Partition Manager

Aug 10 2019

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

QDBus communication

Aug 10 2019, 7:28 PM · KDE Partition Manager
shubham reopened D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 10 2019, 7:27 PM · KDE Partition Manager

Aug 9 2019

shubham updated the diff for D22321: Add unit test for Polkit backend.

Update wrt parent

Aug 9 2019, 1:40 PM · KDE Partition Manager
shubham reopened D22321: Add unit test for Polkit backend.
Aug 9 2019, 1:40 PM · KDE Partition Manager

Aug 7 2019

shubham closed D22321: Add unit test for Polkit backend.
Aug 7 2019, 12:33 PM · KDE Partition Manager
shubham closed D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 7 2019, 12:31 PM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.

Rebase wrt parent

Aug 7 2019, 12:30 PM · KDE Partition Manager
shubham reopened D22321: Add unit test for Polkit backend.
Aug 7 2019, 12:22 PM · KDE Partition Manager
shubham updated the summary of D22321: Add unit test for Polkit backend.
Aug 7 2019, 12:22 PM · KDE Partition Manager
shubham updated the summary of D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 7 2019, 12:16 PM · KDE Partition Manager
fbampaloukas added a watcher for KDE Partition Manager: fbampaloukas.
Aug 7 2019, 4:34 AM

Aug 6 2019

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Remove unwanted signals

Aug 6 2019, 8:24 AM · KDE Partition Manager

Aug 5 2019

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 5 2019, 6:05 PM · KDE Partition Manager
shubham reopened D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 5 2019, 6:04 PM · KDE Partition Manager
shubham closed D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 5 2019, 5:56 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 5 2019, 5:50 PM · KDE Partition Manager
broulik added inline comments to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 5 2019, 5:28 PM · KDE Partition Manager
cjlcarvalho added inline comments to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 5 2019, 5:23 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Rename function

Aug 5 2019, 5:17 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Refactor

Aug 5 2019, 4:55 PM · KDE Partition Manager

Aug 4 2019

shubham added a comment to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

@stikonas Yes, I am planning to re utilize the code, my first intention was just to make it compile.

Aug 4 2019, 12:08 PM · KDE Partition Manager
stikonas added inline comments to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 4 2019, 10:14 AM · KDE Partition Manager
shubham retitled D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application from [WIP]: Send progress through QDBus from helper towards application to [WIP]: Send progress via QDBus from helper towards application.
Aug 4 2019, 6:44 AM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

connect to newData signal in the application

Aug 4 2019, 6:42 AM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Fix errors, make it compile
@stikonas can you have a look please?

Aug 4 2019, 6:30 AM · KDE Partition Manager

Aug 2 2019

stikonas updated subscribers of D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Yes, and you need to add it to cmake. That part of code is autogenerated.

Aug 2 2019, 4:35 PM · KDE Partition Manager
shubham added a comment to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

@stikonas It says error: ‘org’ does not name a type

auto interface = new org::kde::kpmcore::externalcommand(QStringLiteral("org.kde.kpmcore.externalcommand"),

I think I need to add ExternalCommand as an interface.

Aug 2 2019, 2:58 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Refactor

Aug 2 2019, 2:46 PM · KDE Partition Manager
stikonas added a comment to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Before it's pushed (once it compiles) also refactor code a bit so that
there isn't that much code duplication.

Aug 2 2019, 9:17 AM · KDE Partition Manager
shubham added a project to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application: KDE Partition Manager.
Aug 2 2019, 8:52 AM · KDE Partition Manager

Jul 29 2019

shubham closed D22321: Add unit test for Polkit backend.
Jul 29 2019, 3:19 PM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.

Add test to revoke authorization

Jul 29 2019, 2:33 PM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.

Rebase wrt parent

Jul 29 2019, 2:25 PM · KDE Partition Manager
shubham closed D22438: Authorize using Polkit backend and compile Helper as standalone application.
Jul 29 2019, 2:14 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Remove extra line changes

Jul 29 2019, 2:11 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Proper rebase

Jul 29 2019, 2:08 PM · KDE Partition Manager

Jul 28 2019

shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

.

Jul 28 2019, 7:21 AM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Rebase

Jul 28 2019, 7:18 AM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Rebase wrt master

Jul 28 2019, 7:14 AM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.

Rebase wrt parent

Jul 28 2019, 6:37 AM · KDE Partition Manager
shubham abandoned D22593: Compile helper into standalone application.

Merged this with the main patch ie. authorization backend

Jul 28 2019, 6:24 AM · KDE Partition Manager
shubham retitled D22438: Authorize using Polkit backend and compile Helper as standalone application from Authorize using Polkit backend and implement QDBus communication between App and Helper to Authorize using Polkit backend and compile Helper as standalone application.
Jul 28 2019, 6:23 AM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Compile helper as standalone

Jul 28 2019, 6:22 AM · KDE Partition Manager
shubham reopened D22438: Authorize using Polkit backend and compile Helper as standalone application.
Jul 28 2019, 6:22 AM · KDE Partition Manager
shubham closed D22438: Authorize using Polkit backend and compile Helper as standalone application.
Jul 28 2019, 6:17 AM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Rebase on master

Jul 28 2019, 5:58 AM · KDE Partition Manager

Jul 25 2019

shubham retitled D22438: Authorize using Polkit backend and compile Helper as standalone application from [WIP]: Authorize using Polkit backend and implement QDBus communication between App and Helper to Authorize using Polkit backend and implement QDBus communication between App and Helper.
Jul 25 2019, 3:10 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.
Jul 25 2019, 3:02 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Final changes

Jul 25 2019, 3:01 PM · KDE Partition Manager

Jul 21 2019

shubham added inline comments to D22593: Compile helper into standalone application.
Jul 21 2019, 3:13 PM · KDE Partition Manager
stikonas accepted D22593: Compile helper into standalone application.
Jul 21 2019, 9:45 AM · KDE Partition Manager

Jul 20 2019

shubham reopened D22438: Authorize using Polkit backend and compile Helper as standalone application.
Jul 20 2019, 6:53 PM · KDE Partition Manager
shubham added a dependent revision for D22438: Authorize using Polkit backend and compile Helper as standalone application: D22593: Compile helper into standalone application.
Jul 20 2019, 6:50 PM · KDE Partition Manager
shubham added a dependency for D22593: Compile helper into standalone application: D22438: Authorize using Polkit backend and compile Helper as standalone application.
Jul 20 2019, 6:50 PM · KDE Partition Manager
shubham updated the test plan for D22593: Compile helper into standalone application.
Jul 20 2019, 6:50 PM · KDE Partition Manager
shubham updated the diff for D22593: Compile helper into standalone application.

Diff relative to Polkit backend patch

Jul 20 2019, 6:49 PM · KDE Partition Manager
shubham requested review of D22593: Compile helper into standalone application.
Jul 20 2019, 6:48 PM · KDE Partition Manager

Jul 18 2019

shubham closed D22438: Authorize using Polkit backend and compile Helper as standalone application.
Jul 18 2019, 3:33 PM · KDE Partition Manager