In D21261#608154, @shubham wrote:@stikonas I am a bit confused, can you please help a bit?
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Jun 3 2020
Jun 3 2020
Feb 26 2020
Feb 26 2020
Feb 9 2020
Feb 9 2020
Feb 8 2020
Feb 8 2020
@stikonas I am a bit confused, can you please help a bit?
Jan 20 2020
Jan 20 2020
Sorry for typos, What I meant was:
Jan 17 2020
Jan 17 2020
In D21261#595885, @shubham wrote:@stikonas Ping?
@stikonas Ping?
Nov 7 2019
Nov 7 2019
Nov 5 2019
Nov 5 2019
Do you have commit rights or do I need to push it for you?
Sep 1 2019
Sep 1 2019
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Fix unrelated change
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Keep comment at the right place
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Remove unneeded change
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Remove trailing whitespaces
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Some cleanup and add unittest
Aug 30 2019
Aug 30 2019
shubham retitled D23572: Reduce temperature's precision from six decimal places to two from Reduce temperature's precision from six decimal places to one to Reduce temperature's precision from six decimal places to two.
Aug 29 2019
Aug 29 2019
shubham updated the test plan for D23572: Reduce temperature's precision from six decimal places to two.
Aug 26 2019
Aug 26 2019
Rebase
Rebase wrt parent
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
const at the end of startHelper() function
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Use sync version for checking authorization
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Remove left over commented code
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Fix documentation
Aug 25 2019
Aug 25 2019
More changes
Fix linker error
Aug 24 2019
Aug 24 2019
Aug 23 2019
Aug 23 2019
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Remove unused parameters
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Success starting the kauth_externalcommand helper
Aug 22 2019
Aug 22 2019
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Remove commented code
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Refactor
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
- Use checkAuthorizationSync() to authenticate
- Fix infinite recursion in startHelper()
Aug 19 2019
Aug 19 2019
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Try to start the helper(Atleast polkit-qt-1)
Aug 18 2019
Aug 18 2019
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Remove unnecessary linking
Aug 16 2019
Aug 16 2019
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
- Fix runtime warnings inside initPolkitAgent()
- Use "new" inside ctor to instantiate object
Aug 14 2019
Aug 14 2019
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Move helperMain() outside Q_SLOTS
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
some more changes
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Try fixing the inline comments
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Try to fix the broken things
Aug 13 2019
Aug 13 2019
Aug 10 2019
Aug 10 2019
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
QDBus communication
Aug 9 2019
Aug 9 2019
Update wrt parent
Aug 7 2019
Aug 7 2019
Rebase wrt parent
Aug 6 2019
Aug 6 2019
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Remove unwanted signals
Aug 5 2019
Aug 5 2019
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Rename function
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Refactor
Aug 4 2019
Aug 4 2019
shubham added a comment to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
@stikonas Yes, I am planning to re utilize the code, my first intention was just to make it compile.
shubham retitled D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application from [WIP]: Send progress through QDBus from helper towards application to [WIP]: Send progress via QDBus from helper towards application.
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
connect to newData signal in the application
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Fix errors, make it compile
@stikonas can you have a look please?
Aug 2 2019
Aug 2 2019
stikonas updated subscribers of D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Yes, and you need to add it to cmake. That part of code is autogenerated.
shubham added a comment to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
@stikonas It says error: ‘org’ does not name a type
auto interface = new org::kde::kpmcore::externalcommand(QStringLiteral("org.kde.kpmcore.externalcommand"),
I think I need to add ExternalCommand as an interface.
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Refactor
stikonas added a comment to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Before it's pushed (once it compiles) also refactor code a bit so that
there isn't that much code duplication.
Jul 29 2019
Jul 29 2019
Add test to revoke authorization
Rebase wrt parent
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.
Remove extra line changes
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.
Proper rebase
Jul 28 2019
Jul 28 2019
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.
.
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.
Rebase
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.
Rebase wrt master
Rebase wrt parent
Merged this with the main patch ie. authorization backend
shubham retitled D22438: Authorize using Polkit backend and compile Helper as standalone application from Authorize using Polkit backend and implement QDBus communication between App and Helper to Authorize using Polkit backend and compile Helper as standalone application.
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.
Compile helper as standalone