Feed Advanced Search

Today

stikonas added inline comments to D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Mon, Jun 24, 8:01 PM · KDE Partition Manager

Sat, Jun 22

shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Properly handle reply from Authentication agent

Sat, Jun 22, 5:49 PM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

More code cleanup

Sat, Jun 22, 5:27 PM · KDE Partition Manager
stikonas added inline comments to D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Sat, Jun 22, 9:47 AM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

some more changes

Sat, Jun 22, 9:41 AM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Remove unneeded functions

Sat, Jun 22, 9:36 AM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Lay basic outline of executing and revoking actions from inside ExternalCommand

Sat, Jun 22, 9:27 AM · KDE Partition Manager

Fri, Jun 21

shubham updated the summary of D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Fri, Jun 21, 5:55 PM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Correct documentation error

Fri, Jun 21, 5:52 PM · KDE Partition Manager
shubham updated the test plan for D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Fri, Jun 21, 5:50 PM · KDE Partition Manager
shubham added a project to D21970: [WIP]: Implement PolkitQt1 Authorization backend: KDE Partition Manager.
Fri, Jun 21, 5:50 PM · KDE Partition Manager

Thu, Jun 20

shubham updated the diff for D21773: [WIP]: QDBus communication from helper towards Application.

A bit cleanup

Thu, Jun 20, 2:00 PM · KDE Partition Manager

Wed, Jun 19

shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.
Wed, Jun 19, 4:41 PM · KDE Partition Manager

Sun, Jun 16

shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Use correct signal

Sun, Jun 16, 7:47 PM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Add documentation

Sun, Jun 16, 7:37 PM · KDE Partition Manager

Sat, Jun 15

stikonas added a comment to D21564: [WIP]: Implement Authentication Agent/Listener.

I think QSignalSpy is in QtTest, not QtWidgets.

Sat, Jun 15, 7:25 PM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.
  1. Use synchronous versions of register and unregistering authentication agents
  2. Call authenticationAgentResponseSync() on successfull authentication by the user
Sat, Jun 15, 7:13 PM · KDE Partition Manager

Wed, Jun 12

shubham retitled D21773: [WIP]: QDBus communication from helper towards Application from [WIP] :QDBus communication from helper towards Application to [WIP]: QDBus communication from helper towards Application.
Wed, Jun 12, 7:57 PM · KDE Partition Manager
shubham updated the summary of D21773: [WIP]: QDBus communication from helper towards Application.
Wed, Jun 12, 7:57 PM · KDE Partition Manager
shubham added a project to D21773: [WIP]: QDBus communication from helper towards Application: KDE Partition Manager.
Wed, Jun 12, 7:56 PM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Rebase on master

Wed, Jun 12, 4:54 PM · KDE Partition Manager

Mon, Jun 10

shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Add more functions

Mon, Jun 10, 4:22 PM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Do not include PolkitQt5 directories

Mon, Jun 10, 2:51 PM · KDE Partition Manager

Sun, Jun 9

stikonas added a comment to D21564: [WIP]: Implement Authentication Agent/Listener.

So far rest seems alright.

Sun, Jun 9, 10:08 PM · KDE Partition Manager

Sat, Jun 8

shubham closed D21653: Add Minix Filesystem.
Sat, Jun 8, 6:32 PM · KDE Partition Manager
shubham closed D21652: Add support for Minix(Mini Unix) Filesystem.
Sat, Jun 8, 6:31 PM · KDE Partition Manager
shubham updated the summary of D21653: Add Minix Filesystem.
Sat, Jun 8, 6:30 PM · KDE Partition Manager
stikonas accepted D21653: Add Minix Filesystem.
Sat, Jun 8, 6:29 PM · KDE Partition Manager
shubham updated the diff for D21653: Add Minix Filesystem.

Fix copy paste error

Sat, Jun 8, 6:24 PM · KDE Partition Manager
stikonas accepted D21653: Add Minix Filesystem.

Once issues mentioned above are fixed.

Sat, Jun 8, 6:19 PM · KDE Partition Manager
stikonas accepted D21652: Add support for Minix(Mini Unix) Filesystem.
Sat, Jun 8, 6:15 PM · KDE Partition Manager
shubham updated the diff for D21652: Add support for Minix(Mini Unix) Filesystem.

Make requested changes

Sat, Jun 8, 6:13 PM · KDE Partition Manager
stikonas requested changes to D21653: Add Minix Filesystem.
Sat, Jun 8, 5:59 PM · KDE Partition Manager
stikonas added inline comments to D21652: Add support for Minix(Mini Unix) Filesystem.
Sat, Jun 8, 5:53 PM · KDE Partition Manager
stikonas added inline comments to D21652: Add support for Minix(Mini Unix) Filesystem.
Sat, Jun 8, 5:45 PM · KDE Partition Manager
stikonas requested changes to D21652: Add support for Minix(Mini Unix) Filesystem.
Sat, Jun 8, 5:25 PM · KDE Partition Manager
shubham updated the diff for D21652: Add support for Minix(Mini Unix) Filesystem.

Correct tool name and website

Sat, Jun 8, 5:11 PM · KDE Partition Manager
stikonas requested changes to D21652: Add support for Minix(Mini Unix) Filesystem.
Sat, Jun 8, 4:46 PM · KDE Partition Manager
shubham closed D21616: Quit application if bus is not connected, interface not registered.
Sat, Jun 8, 10:14 AM · KDE Partition Manager
stikonas accepted D21616: Quit application if bus is not connected, interface not registered.
Sat, Jun 8, 10:07 AM · KDE Partition Manager
stikonas added a comment to D21616: Quit application if bus is not connected, interface not registered.

Oh, I see. Sorry for missing that out. Then I guess commit it to master.

Sat, Jun 8, 10:07 AM · KDE Partition Manager
shubham updated the diff for D21652: Add support for Minix(Mini Unix) Filesystem.

Made suggested changes

Sat, Jun 8, 10:00 AM · KDE Partition Manager
shubham added a comment to D21616: Quit application if bus is not connected, interface not registered.

This is seprate from the patch sitter had made. Here, application quitting is inside if.

Sat, Jun 8, 9:42 AM · KDE Partition Manager
stikonas added inline comments to D21652: Add support for Minix(Mini Unix) Filesystem.
Sat, Jun 8, 8:54 AM · KDE Partition Manager
stikonas added inline comments to D21652: Add support for Minix(Mini Unix) Filesystem.
Sat, Jun 8, 8:53 AM · KDE Partition Manager
stikonas requested changes to D21616: Quit application if bus is not connected, interface not registered.

If you want this commit, you can just merge master branch into your branch.

Sat, Jun 8, 8:50 AM · KDE Partition Manager
shubham added a comment to D21652: Add support for Minix(Mini Unix) Filesystem.

[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[New Thread 0x7fffe809d700 (LWP 4495)]
[New Thread 0x7fffdf322700 (LWP 4501)]
Could not load plugin for core backend "" : "The shared library was not found."
Loaded backend plugin: "pmsfdiskbackendplugin"
[New Thread 0x7fffd21a8700 (LWP 4502)]
[New Thread 0x7fffd19a7700 (LWP 4503)]
[New Thread 0x7fffcbb90700 (LWP 4504)]
[New Thread 0x7fffcb38f700 (LWP 4505)]
"Using backend plugin: pmsfdiskbackendplugin (1)"
"Scanning devices..."
[New Thread 0x7fffca6df700 (LWP 4550)]
"Device found: ST500LT012-1DG14"
smartctl initialization failed for "/dev/sda" : No such file or directory
error during smart output parsing for "/dev/sda" : No such file or directory

Sat, Jun 8, 6:06 AM · KDE Partition Manager
shubham updated the diff for D21652: Add support for Minix(Mini Unix) Filesystem.

Add mkfs.minix and fsck.minix to externalcommand_whitelist.h

Sat, Jun 8, 5:34 AM · KDE Partition Manager

Fri, Jun 7

cjlcarvalho added inline comments to D21652: Add support for Minix(Mini Unix) Filesystem.
Fri, Jun 7, 11:39 PM · KDE Partition Manager
cjlcarvalho requested changes to D21652: Add support for Minix(Mini Unix) Filesystem.

You will need to add fsck.minix to our command whitelist.

Fri, Jun 7, 11:38 PM · KDE Partition Manager
cjlcarvalho accepted D21653: Add Minix Filesystem.

Yes, I could. It is being showed.

Fri, Jun 7, 11:33 PM · KDE Partition Manager
shubham updated the diff for D21652: Add support for Minix(Mini Unix) Filesystem.

Remove redundant include

Fri, Jun 7, 8:09 PM · KDE Partition Manager
shubham updated the summary of D21653: Add Minix Filesystem.
Fri, Jun 7, 7:42 PM · KDE Partition Manager
shubham updated the diff for D21653: Add Minix Filesystem.

Rebase

Fri, Jun 7, 7:34 PM · KDE Partition Manager
shubham added a comment to D21653: Add Minix Filesystem.

@cjlcarvalho Did you see minix added to the menu? Can you please try applying the patch?

Fri, Jun 7, 7:01 PM · KDE Partition Manager
cjlcarvalho accepted D21653: Add Minix Filesystem.
Fri, Jun 7, 6:58 PM · KDE Partition Manager
shubham updated the diff for D21653: Add Minix Filesystem.

Whitespace consistency

Fri, Jun 7, 6:47 PM · KDE Partition Manager
stikonas accepted D21652: Add support for Minix(Mini Unix) Filesystem.
Fri, Jun 7, 6:45 PM · KDE Partition Manager
stikonas accepted D21653: Add Minix Filesystem.
Fri, Jun 7, 6:42 PM · KDE Partition Manager
shubham updated the diff for D21652: Add support for Minix(Mini Unix) Filesystem.

Whitespace consistency

Fri, Jun 7, 6:38 PM · KDE Partition Manager
shubham added a project to D21653: Add Minix Filesystem: KDE Partition Manager.
Fri, Jun 7, 6:36 PM · KDE Partition Manager
stikonas requested changes to D21652: Add support for Minix(Mini Unix) Filesystem.

Looks good, just keep space consistent where I mentioned. Then you can push this to master branch.

Fri, Jun 7, 6:04 PM · KDE Partition Manager
shubham added a project to D21652: Add support for Minix(Mini Unix) Filesystem: KDE Partition Manager.
Fri, Jun 7, 5:59 PM · KDE Partition Manager
stikonas added a comment to D21617: Handle action authorization inside helper.

I think startHelper() is much better.

Fri, Jun 7, 2:25 PM · KDE Partition Manager
shubham updated the diff for D21617: Handle action authorization inside helper.

Rebase

Fri, Jun 7, 2:25 PM · KDE Partition Manager
shubham added inline comments to D21617: Handle action authorization inside helper.
Fri, Jun 7, 2:21 PM · KDE Partition Manager
shubham updated the diff for D21617: Handle action authorization inside helper.

Remove FindPolkitQt1.cmake

Fri, Jun 7, 4:21 AM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Made suggested changes

Fri, Jun 7, 4:17 AM · KDE Partition Manager

Thu, Jun 6

stikonas added inline comments to D21564: [WIP]: Implement Authentication Agent/Listener.
Thu, Jun 6, 9:01 PM · KDE Partition Manager
stikonas added inline comments to D21564: [WIP]: Implement Authentication Agent/Listener.
Thu, Jun 6, 8:57 PM · KDE Partition Manager
cjlcarvalho added inline comments to D21617: Handle action authorization inside helper.
Thu, Jun 6, 8:53 PM · KDE Partition Manager
shubham added a dependency for D21617: Handle action authorization inside helper: D21564: [WIP]: Implement Authentication Agent/Listener.
Thu, Jun 6, 10:05 AM · KDE Partition Manager
shubham added a dependent revision for D21564: [WIP]: Implement Authentication Agent/Listener: D21617: Handle action authorization inside helper.
Thu, Jun 6, 10:05 AM · KDE Partition Manager
shubham updated the diff for D21617: Handle action authorization inside helper.

diff relative to D21564

Thu, Jun 6, 10:04 AM · KDE Partition Manager
shubham requested review of D21617: Handle action authorization inside helper.
Thu, Jun 6, 10:02 AM · KDE Partition Manager
shubham added a project to D21616: Quit application if bus is not connected, interface not registered: KDE Partition Manager.
Thu, Jun 6, 9:07 AM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Some more cleanup

Thu, Jun 6, 8:44 AM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Remove unneded includes and use Q_UNUSED() variables

Thu, Jun 6, 8:40 AM · KDE Partition Manager

Wed, Jun 5

shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Unregistration of the auth agent

Wed, Jun 5, 5:01 PM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Proper rebase

Wed, Jun 5, 3:55 PM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Move FindPolkitQt1.cmake to cmake/modules/

Wed, Jun 5, 3:52 PM · KDE Partition Manager

Tue, Jun 4

shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Remove extra variable

Tue, Jun 4, 3:29 PM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Use authority instance to register the listener

Tue, Jun 4, 7:56 AM · KDE Partition Manager
shubham reopened D21564: [WIP]: Implement Authentication Agent/Listener.
Tue, Jun 4, 7:56 AM · KDE Partition Manager
shubham closed D21564: [WIP]: Implement Authentication Agent/Listener.
Tue, Jun 4, 7:13 AM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Update my copyright mail id

Tue, Jun 4, 7:10 AM · KDE Partition Manager

Mon, Jun 3

shubham updated the summary of D21564: [WIP]: Implement Authentication Agent/Listener.
Mon, Jun 3, 9:20 PM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Builds, Compiles, Links

Mon, Jun 3, 9:20 PM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Made changes as suggested.
Updated version, still does not compile

Mon, Jun 3, 7:52 PM · KDE Partition Manager
stikonas added inline comments to D21564: [WIP]: Implement Authentication Agent/Listener.
Mon, Jun 3, 7:37 PM · KDE Partition Manager
stikonas requested changes to D21564: [WIP]: Implement Authentication Agent/Listener.
Mon, Jun 3, 7:34 PM · KDE Partition Manager
shubham added a comment to D21564: [WIP]: Implement Authentication Agent/Listener.

How do I include that FindPolKitQt1.cmake file so that I can use it in my project?

Mon, Jun 3, 5:59 PM · KDE Partition Manager
shubham added a project to D21564: [WIP]: Implement Authentication Agent/Listener: KDE Partition Manager.
Mon, Jun 3, 3:25 PM · KDE Partition Manager

Thu, May 30

shubham closed D21504: Notify user when they enter non whitelisted command.
Thu, May 30, 5:57 PM · KDE Partition Manager
stikonas accepted D21504: Notify user when they enter non whitelisted command.
Thu, May 30, 5:55 PM · KDE Partition Manager
shubham updated the diff for D21504: Notify user when they enter non whitelisted command.

Add command name

Thu, May 30, 5:47 PM · KDE Partition Manager
stikonas requested changes to D21504: Notify user when they enter non whitelisted command.
Thu, May 30, 5:32 PM · KDE Partition Manager
shubham added a project to D21504: Notify user when they enter non whitelisted command: KDE Partition Manager.
Thu, May 30, 5:06 PM · KDE Partition Manager

May 25 2019

stikonas added inline comments to D21340: [RFC]Add unit test for RAID.
May 25 2019, 3:21 PM · KDE Partition Manager
shubham updated the diff for D21340: [RFC]Add unit test for RAID.

Add test for RAID craetion

May 25 2019, 2:59 PM · KDE Partition Manager