- Need to set "Regular" style name font to avoid not equal font
BUG: 416358
Lint Skipped |
Unit Tests Skipped |
Buildable 21499 | |
Build 21517: arc lint + arc unit |
kcms/fonts/fontssettings.kcfg | ||
---|---|---|
77 | Won't this worsen https://bugs.kde.org/show_bug.cgi?id=378523? |
kcms/fonts/fonts.cpp | ||
---|---|---|
473 | You can make this static. |
kcms/fonts/fonts.cpp | ||
---|---|---|
479 | Kinda defies the purpose of using kconfigxt if we end up hardcoding the state in code again? |
kcms/fonts/fonts.cpp | ||
---|---|---|
479 | That part was never transitioned to KConfigXT though since it doesn't have a KConfig backend. Clearly inheriting by hand from KCoreConfigSkeleton should be next on the options to be evaluated (not in that patch though). |
kcms/fonts/fontssettings.kcfg | ||
---|---|---|
77 | This is only the default value, and default value will be not bold or italic so we will not have this kind of problem AFAIK. |
kcms/fonts/fonts.cpp | ||
---|---|---|
473 | Just a nitpick, I guess you plan to change it soon. |
kcms/fonts/fonts.cpp | ||
---|---|---|
473 | It will be changed when we migrate this part to kconfigxt |
We are getting duplicates of https://bugs.kde.org/show_bug.cgi?id=416358, so I guess it would be nice if this made it into 5.18.
Does this mean the default fonts have a style name of "Regular" now? That will break setting bold fonts and such, see https://phabricator.kde.org/D9070.
Default is not serialized in the configuration file (because it's the default value).
I do some check with current KCM version, and when we save it, we end up with font=Noto Sans,10,-1,5,87,1,0,0,0,0,Regular
Because nearest font algorithm return the regular one. So if I well understood everything this patch will not break anything.