Adds an option to open externally called folder in a new tab.
By default this option is enabled
elvisangelaccio | |
ngraham |
Dolphin |
Adds an option to open externally called folder in a new tab.
By default this option is enabled
If option selected:
If option not selected:
This option does not require Dolphin to be restarted to take effect.
No Linters Available |
No Unit Test Coverage |
Buildable 13205 | |
Build 13223: arc lint + arc unit |
Thanks! Will review once the feature in and of itself works reliably enough for me to test it in various use cases; first I'd like to see https://bugs.kde.org/show_bug.cgi?id=408244 and https://bugs.kde.org/show_bug.cgi?id=408387 fixed.
src/settings/startup/startupsettingspage.cpp | ||
---|---|---|
104 | Can we find a different wording here? I feel like "externally called" is too technical. Maybe just a simpler "Open new folders in a tab" ? |
src/settings/startup/startupsettingspage.cpp | ||
---|---|---|
104 | I feel like we need to make it clear just what will be opened in a new tab, or else some people might think that regular navigation using their existing window will create new tabs. Maybe "Open new tabs instead of new windows"? |
src/settings/startup/startupsettingspage.cpp | ||
---|---|---|
104 | Okular (which has the same feature) presents the option as "open new files in tabs", so I've opted for "open new folders in tabs" for consistency. |
Ran into an interesting bug with this. With the feature turned off, using the "Open Containing Folder" feature in many KDE apps causes a new Dolphin window to open with the path of the file itself, not its containing folder. As a result, the file gets opened a second time.
With the feature turned on, everything works properly and the file's containing folder is opened in a new tab in the running Dolphin instance
Does it still occur if you rebase this patch onto master (now that D21691 has been committed)?
Be careful when you say nope/yes ;) was very confused if you meant rebasing it solved it or not.
So for example if you open a jpg, and ask to open in containing folder it'll reopen in gwenview and also be selected in Dolphin?
Oh gosh, I'm sorry. I'm too tired for this right now and need to go to bed.
So for example if you open a jpg, and ask to open in containing folder it'll reopen in gwenview and also be selected in Dolphin?
Almost. Here's a video that shows the issue (with apologies to @broulik):
Ok I have a fix up. Again, can't replicate so please test for me. Hope I haven't derailed the sprint too much :D
Thanks, the issue is fixed now. I could not find any other behavioral regressions, and I've verified that the new feature behaves correctly. The code looks good to me too!
Next, do you think you could work on https://bugs.kde.org/show_bug.cgi?id=408919?
I think it would be more appropriate to focus on GSoC at the moment, so until the 19th August, which i think will probably fall after 19.08.0 anyway. So I guess, time permitting, I'll aim for 19.12.0. If I go to Akademy could possibly do it there, especially as I don't know the workflow of activities/virtual desktops that well.