WIP: Add KFileItemActionsPlugin
AbandonedPublic
Actions

Authored by broulik on May 15 2018, 1:36 PM.

Details

Reviewers

Group Reviewers

Plasma
VDG

Summary

Allows to share files from Dolphin's file context menu and notification thumbnails.

Test Plan

Menu shows different actions depending on file type, e.g. imgur is only offered for images

TODO: When I click Imgur, the progress dialog shows up but the finished handler is never invoked :(

Diff Detail

Repository

R495 Purpose Library

Lint

Lint Skipped

Unit

Unit Tests Skipped

broulik created this revision.May 15 2018, 1:36 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptMay 15 2018, 1:36 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

broulik requested review of this revision.May 15 2018, 1:36 PM

Fantastic! I've wanted this for so long!

That "send as email attachment" item you have in your Dolphin context menu... is that a separate service item provided by KMail that will become obsolete with this new share menu? Seems kinda redundant to have them both...

elvisangelaccio added a subscriber: elvisangelaccio.May 15 2018, 8:37 PM

elvisangelaccio added inline comments.

src/fileitemactionplugin/purposefileitemaction.desktop
1–8	Why not just starting with JSON metadata? (since this is a new plugin)

broulik mentioned this in D13124: Add Share action to Dolphin context menu.May 27 2018, 8:48 AM

nicolasfella added a subscriber: nicolasfella.May 27 2018, 12:34 PM

nicolasfella added inline comments.

src/fileitemactionplugin/sharefileitemaction.cpp
83	mimeType() can be empty which can cause problems (see D12728). Not sure if it will here though
91	You can use m_purposeMenu->menuAction()

Superseded by D13124

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (2 lines)
M		src/CMakeLists.txt (1 line)
A	M	src/fileitemactionplugin/CMakeLists.txt (14 lines)
A	M	src/fileitemactionplugin/purposefileitemaction.desktop (8 lines)
A	M	src/fileitemactionplugin/sharefileitemaction.h (46 lines)
A	M	src/fileitemactionplugin/sharefileitemaction.cpp (98 lines)