MIT relicensing
Closed, ResolvedPublic

Description

Seems the Qt people are ok with using it.
David Schulz does a lot of work there, e.g. he implements the language server protocol stuff, too.
Therefore I think it is OK if he is willing to do it.

Mail on creator list:

Hi,

After a first look it seems that the transition to the KSyntaxHighlighter should be pretty straight forward, just some minor adjustments to the state handling. So let's wait for any kind of licensing decision and we are good to go.

Greetings
David

A quick grep for all authors of stuff in src/ shows up not many people:

Author: Aleix Pol <aleixpol@kde.org>
Author: Burkhard Lück <lueck@hube-lueck.de>
Author: Christoph Cullmann <cullmann@kde.org>
Author: David Faure <faure@kde.org>
Author: Dominik Haumann <dhaumann@kde.org>
Author: Friedrich W. H. Kossebau <kossebau@kde.org>
Author: Kevin Funk <kfunk@kde.org>
Author: Laurent Montel <montel@kde.org>
Author: Luigi Toscano <luigi.toscano@tiscali.it>
Author: Michael Hansen <zrax0111@gmail.com>
Author: Montel Laurent <montel@kde.org>
Author: R.J.V. Bertin <rjvbertin@gmail.com>
Author: Thomas Friedrichsmeier <thomas.friedrichsmeier@ruhr-uni-bochum.de>
Author: Volker Krause <vkrause@kde.org>

Aleix Pol <aleixpol@kde.org>, only buildsystem

commit 683fc509a1ad5ac36e2446cf35a123f479455636
Author: Aleix Pol <aleixpol@kde.org>
Date: Tue Mar 27 03:59:14 2018 +0200

Make it possible to fully build the project when crosscompiling

Burkhard Lück <lueck@hube-lueck.de>, only message extraction fix

commit 03ae61fe296fb517b2c81dcaa789e229b28f8522
Author: Burkhard Lück <lueck@hube-lueck.de>
Date: Mon Sep 26 09:49:57 2016 +0200

fix Messages.sh

Christoph Cullmann <cullmann@kde.org>

=> I agree with MIT :=)

David Faure <faure@kde.org>, only typo

commit 1ac18fd31cec6468090930f5afb40ced201c0fe0
Author: David Faure <faure@kde.org>
Date: Fri Sep 30 10:08:33 2016 +0200

fix typo

Dominik Haumann <dhaumann@kde.org>

=> obviously agrees, as wanted this, too

commit 6891e5a138481b05286176b2738de382a5dda0a2
Author: Friedrich W. H. Kossebau <kossebau@kde.org>
Date: Tue Dec 6 17:41:11 2016 +0100

[FEATURE] Option to build & install QCH file with the public API dox

> only buildsystem related stuff

commit 2145da7a6dc730022804eb6a92a99877ccca9c4a
Author: Kevin Funk <kfunk@kde.org>
Date: Tue Aug 22 16:53:26 2017 +0200

indexer: Use qWarning for every error message

Use the same debug level for all errors

commit 28283da775d55c3849783dbe4bbb58a55b52d59e
Author: Kevin Funk <kfunk@kde.org>
Date: Tue Jun 13 19:44:39 2017 +0200

indexer: Improve error reporting

commit b9d01c7854a2633746688d6daff2af89ae92bc14
Author: Kevin Funk <kfunk@kde.org>
Date: Mon Jan 16 18:17:34 2017 +0100

Prefer nullptr over Q_NULLPTR

> we should ask Kevin, even if it mostly style stuff

commit 951275601189dbfced87c512ef4720cbe86edd6e
Author: Laurent Montel <montel@kde.org>
Date: Mon May 28 07:01:03 2018 +0200

Use override

commit ace77db4ed293c41cab885e83d17193e74e20541
Author: Laurent Montel <montel@kde.org>
Date: Tue Apr 17 06:45:28 2018 +0200

Add missing Q_DECL_OVERRIDE, warning--

commit a0bbe1a493559c2877ddb2f23c75e22f820596ba
Author: Montel Laurent <montel@kde.org>
Date: Tue Sep 20 17:57:58 2016 +0200

Add target_include_directories for interface

commit 99faeff9109338b8fc968e2697318d50c6228615
Author: Montel Laurent <montel@kde.org>
Date: Mon Sep 12 11:58:16 2016 +0200

Fix typo

> Laurent only the normal compile/warning fixes

commit 6db41ca680849a7f567229e18d0ed700dd7369b1
Author: Luigi Toscano <luigi.toscano@tiscali.it>
Date: Sat Sep 10 16:36:40 2016 +0200

Fix translations for the syntax-highlighting module

> we can ask Luigi

commit b8d4bb51c5db06b6cc466b77835bab216f95c1a1
Author: Michael Hansen <zrax0111@gmail.com>
Date: Fri Sep 29 18:42:32 2017 +0200

Add support for custom search paths for application-specific syntax and theme definitions

> we should ask Michael

commit 804f15240bdcbc2a4e11dd2c635e0bfb794f30e4
Author: R.J.V. Bertin <rjvbertin@gmail.com>
Date: Tue Nov 22 22:36:27 2016 +0100

kate-syntax-highlighter is a command line utility.

Don't build it as an app bundle on Mac.

> buildsystem fix only

commit e48e34bd02886abcc7d1b516d6b8eb3d7713bad5
Author: Thomas Friedrichsmeier <thomas.friedrichsmeier@ruhr-uni-bochum.de>
Date: Tue Jun 6 21:17:42 2017 +0200

Add since tags.

> no need to ask

Ok, we need to ask "you" and Michael, Luigi and Kevin, than all things in src/ should be fine.

I'm ok with this too.

Should I mail the three people? Or do you want to take care as magic maintainer? :=)

I also agree to relicense all of my work in the KSyntaxHighlighting framework to the MIT license.

Please do if you have the time, Akademy left me with plenty of todo items already ;-)

Roger, roger :P

I agree with the relicensing to MIT of all my work in the KSyntaxHighlighting framework (which at this point really means only one change which I even forgot until now).

kfunk added a subscriber: kfunk.Aug 20 2018, 1:00 PM

I'm okay with this.

dhaumann added a subscriber: zrax.Aug 20 2018, 3:06 PM

@zrax Could you give your ok here as well?

zrax added a comment.Aug 20 2018, 4:17 PM

Yes, I agree with the relicensing of my work to MIT in the KSyntaxHighlighting framework.

Then all ack'd that ;=)

Shall I replace the license headers with something like
https://choosealicense.com/licenses/mit/

MIT License

Copyright (c) [year] [fullname]

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

If the license text above matches https://community.kde.org/Policies/Licensing_Policy#MIT_license then please go ahead.

I addition, I would like to announce this on kde-community@kde.org, and I would like to have a discussion about dual licensing of LGPL + e.V. for commercial use (not related to this now, still, just to raise the awareness).

We missed Sebastian Pipping <webmaster@hartwork.org> as that was only in the copyright headers.
I wrote him a mail, lets see what he says.

cullmann claimed this task.Aug 20 2018, 9:14 PM

Beside Sebastian's stuff, the src/ things are now with MIT notice.
I added me and Dominik to the definition.cpp header, too.
Sebastian already mailed me in private back, after he ack'd in public, the last two files can move.
Then the toplevel license file can be swapped.

Excellent, thanks for getting this done!

I patched the buildsystem to allow static builds of the library, works for me on macOS, Windows & Linux.

I have redone the wildcard matching. Now we just use a combined QRegularExpression and export that for use in e.g. KTextEditor

https://phabricator.kde.org/D15081

If that change goes in, all "code" is MIT, beside some generator scripts and most of the syntax definition files.

cullmann closed this task as Resolved.Aug 25 2018, 4:53 PM

Git commit df0b691480d89726c2a7826d9fb06a46244d7414 by Christoph Cullmann.
Committed on 25/08/2018 at 16:49.
Pushed by cullmann into branch 'master'.

MIT relicensing of KSyntaxHighlighting done

all authors agreed

Sebastian Pipping ack'd on kwrite-devel@kde.org

more details see https://phabricator.kde.org/T9455
or kwrite-devel@kde.org archives

A +20 -0 COPYING
D +0 -510 COPYING.LIB
M +22 -18 autotests/wildcardmatcher_test.cpp
M +22 -18 src/lib/wildcardmatcher.cpp
M +22 -18 src/lib/wildcardmatcher_p.h

https://commits.kde.org/syntax-highlighting/df0b691480d89726c2a7826d9fb06a46244d7414

> Done, thanks to all!