[WIP] introduce GenericDataModel and ModelDataCache to have a generic model
AbandonedPublic

Authored by mgallien on May 9 2018, 5:07 PM.

Details

Summary

introduce GenericDataModel and ModelDataCache to have a generic model

add new methods to DatabaseInterface to have a fully generic way to
fetch data from it and feed them into a generic model

try to implement GenericDataModel

basic browsing of all albums, all artists and all tracks

will easily enable to add browsing by genre

Test Plan

do not yet work but basic browsing in the views mostly works

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien requested review of this revision.May 9 2018, 5:07 PM
mgallien created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 9 2018, 5:09 PM
This revision was automatically updated to reflect the committed changes.

I have pushed the branch to the repository as genericModel .
I plan to complete the generic model while keeping it asynchronous and not blocking. After that, I plan to work on the user interface to allow basic genre browsing and more if time permits.

mgallien reopened this revision.May 9 2018, 5:11 PM

It has been closed when I have pushed the branch. Sorry for the noise.

Will the other models eventually be migrated to use only this model? Can you explain the plan?
As a wish, browsing by year is also a nice to have feature.

src/elisautils.h
85

We are slowly putting everything that needs to be shared and does not belong elsewhere into elisautils.
I think we should be careful to not accumulate lots of unrelated code in here.

Will the other models eventually be migrated to use only this model? Can you explain the plan?
As a wish, browsing by year is also a nice to have feature.

I will add it. I had somehow missed it.

I would like to remove a lot of duplicated code in the existing models by a more generic one.

If I succeed, we should have a generic model that is also not blocking. I hope to have something less complex than D11167.

mgallien abandoned this revision.Aug 23 2018, 3:43 PM