Details

Yes but with multiple revision in it. Until I rebase the branch, you get the error. This is because the parent commit of D12548 is not in the master branch because arc does change the commit hash. You should be fine after I have refreshed the diff request. this what I did a few minutes after your message. Sorry for the list time.

astippich accepted this revision.May 1 2018, 5:30 PM

This revision is now accepted and ready to land.May 1 2018, 5:30 PM

Closed by commit R255:9a7d8e251737: extend MusicAudioTrack constructor to include lyricist and update tests (authored by mgallien). · Explain WhyMay 1 2018, 6:25 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			autotests/albummodeltest.cpp (55 lines)
M			autotests/allalbumsmodeltest.cpp (52 lines)
M			autotests/allartistsmodeltest.cpp (49 lines)
M			autotests/alltracksmodeltest.cpp (64 lines)
M			autotests/alltracksproxymodeltest.cpp (62 lines)
M			autotests/databaseinterfacetest.cpp (186 lines)
M			autotests/localfilelistingtest.cpp (46 lines)
M			autotests/manageheaderbartest.h (46 lines)
M			autotests/managemediaplayercontroltest.h (46 lines)
M			autotests/mediaplaylisttest.h (46 lines)
M			autotests/trackslistenertest.cpp (49 lines)
M			src/musicaudiotrack.h (3 lines)
M			src/musicaudiotrack.cpp (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	33170	a954e34		Apr 26 2018, 8:25 PM	★	★
Diff 2	33381	4598952	rebase on top of master	May 1 2018, 11:54 AM	★	★
Diff 3	33407	ed1dcc5	rebase on top of master	May 1 2018, 4:43 PM	★	★
Diff 4	33408	ed1dcc5	once more just to be sure	May 1 2018, 4:46 PM	★	★
Diff 5	33416	11b685b	R255:9a7d8e25173774db23415950378e8efe40df9813	May 1 2018, 6:25 PM	★	★

extend MusicAudioTrack constructor to include lyricist and update tests
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 33416

autotests/albummodeltest.cpp

autotests/allalbumsmodeltest.cpp

autotests/allartistsmodeltest.cpp

autotests/alltracksmodeltest.cpp

autotests/alltracksproxymodeltest.cpp

autotests/databaseinterfacetest.cpp

autotests/localfilelistingtest.cpp

autotests/manageheaderbartest.h

autotests/managemediaplayercontroltest.h

autotests/mediaplaylisttest.h

autotests/trackslistenertest.cpp

src/musicaudiotrack.h

src/musicaudiotrack.cpp

extend MusicAudioTrack constructor to include lyricist and update testsClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 33416

autotests/albummodeltest.cpp

autotests/allalbumsmodeltest.cpp

autotests/allartistsmodeltest.cpp

autotests/alltracksmodeltest.cpp

autotests/alltracksproxymodeltest.cpp

autotests/databaseinterfacetest.cpp

autotests/localfilelistingtest.cpp

autotests/manageheaderbartest.h

autotests/managemediaplayercontroltest.h

autotests/mediaplaylisttest.h

autotests/trackslistenertest.cpp

src/musicaudiotrack.h

src/musicaudiotrack.cpp

extend MusicAudioTrack constructor to include lyricist and update tests
ClosedPublic
Actions

Revision Contents
Changeset List