Create Task
Maniphest T14188

Krita UI refresh spring 2021
Open, Needs TriagePublic
Actions

Description

Description:

Animtim & scottyp are working on icons and UI changes in Krita to make it more polished. There are however some issues, and since there is no MR and it's probably not a good idea to start a KA thread or make bug reports about them, I'll list them here. If it's fixed, please feel free to cross them off.

Issues:

  • File -> New -> New Document dialog has buttons for horizontal and vertical canvas size.
    • in stable/4.4.2, the current one is highlighted in blue and it looked good.
    • on master (0d4c96259d), the current one has just dark color (Fusion, with default Krita's theme), and now it's difficult to tell which button is pressed unless you look very closely.
  • on master (0d4c96259d), Tool Options for selection tools (checked with Rectangle Selection Tool):
    • select Rectangle Selection Tool
    • select Pixel Selection in Tool Options
    • select Freehand Brush Tool
    • select Rectangle Selection Tool: see, in Tool Options the pixel selection button is darkened and the vector selection button is highlighted.
    • correct pixel selection marking:
    • correct vector selection marking:
  • on master (0d4c96259d), Brush Tip -> Auto/Predefined/Text
    • I don't know how exactly would I get this result, but I did get it:
    • as you can see, the tab chosen (and here, darkened) is Predefined, but Auto is highlighted.
  • on master (bc233c344b) Tab names
    • cutting of the name is difficult to read/recognize
    • too much vertical space
  • (fixed in https://invent.kde.org/graphics/krita/-/commit/2685304ce02c96a131ae0cca91dd379585e88d10 )

on master () Image -> Scale to a New Size, or Image -> Resize canvas, or the same features for a Layer, or Transform Tool -> Scale, or probably other places. I think all of the instances of those icons are wrong on my system now.

  • the chain icons are too big and cropped

Related Objects
Search...

StatusAssignedTask
 OpenNoneT14188 Krita UI refresh spring 2021
 ResolvedtimotheegietT14190 Krita UI refresh - ideas
tymond created this task.Mar 9 2021, 8:20 PM
mwein added a subscriber: mwein.Mar 9 2021, 10:23 PM

Docker tabs don't really elide text in a useful way after commit bc233c344b4dcd1bb54d28af470399c3d37d2f69, and somehow the inactive tab corners seem to bend outwards.
With the (otherwise duplicated) docker title also removed, you have to rely on the tooltip to actually figure out the docker name.

Also, compared to Fusion style they take significantly more vertical space, and just look much more alien than in Breeze.

scottpetrovic added a subscriber: scottpetrovic.EditedMar 10 2021, 1:21 AM

@mwein - There are too many styles probably applied to those tabs. We can probably remove some. I originally got the styles from the Krita UI redesign plugin. I removed a lot of the random styling. Having 4 docker tabs in a little area can only get so good though.
https://invent.kde.org/graphics/krita/-/merge_requests/743

On another note, where did the titles go for the dockers? The titles for the dockers seem to all have disappeared. You can only see the title if they are in a tab now

mwein added a comment.Mar 10 2021, 7:15 AM
In T14188#251142, @scottpetrovic wrote:

On another note, where did the titles go for the dockers? The titles for the dockers seem to all have disappeared. You can only see the title if they are in a tab now

I believe it was Commit 634066b5 by Timothée

And yes that of course is a bit of an extreme example of tabs, like the old style can only display "La..." for the Layers docker.
But still, some docker names are pretty long like "Advanced Color Selector", and reading "Advanced Colo..." makes it a lot easier to see if the docker is still open. The middle of the text with cut off letters on both sides is a bit too irritating for me.

I start to wonder if there's really no better option than Qt's CSS engine, but there really doesn't seem to be a lot of style engines with customization in mind. Kvantum at least seems actively developed and offers more than a bunch of colors and option switches, but the SVG approach seems a bit complicated for maintaining multiple color themes.

kamathraghavendra added a subscriber: timotheegiet.EditedMar 10 2021, 7:24 AM
In T14188#251142, @scottpetrovic wrote:

On another note, where did the titles go for the dockers? The titles for the dockers seem to all have disappeared. You can only see the title if they are in a tab now

@timotheegiet is still working on it. Now the single docker has title missing. I think Animtim said he is going to look in to it and there is still work to do.

kamathraghavendra added a comment.Mar 10 2021, 7:27 AM

GIMP and possibly other software convert the docker title name into an icon when it is too short to show the name. Can we do that instead of only using ellipsis. We can ellide the end of the names when required but if user adds more tabs it is always going to get smaller. In such cases we can change the title into an icon and then may be add arrows to scroll tabs like how firefox does.

timotheegiet added a comment.Mar 10 2021, 12:06 PM
In T14188#251158, @kamathraghavendra wrote:
In T14188#251142, @scottpetrovic wrote:

On another note, where did the titles go for the dockers? The titles for the dockers seem to all have disappeared. You can only see the title if they are in a tab now

@timotheegiet is still working on it. Now the single docker has title missing. I think Animtim said he is going to look in to it and there is still work to do.

Actually after thinking further I feel it's better to keep the name of the dockers on the titlebar, to always have at least one place where we can be sure they will show in full in most cases. The duplication with the title in the tab is not really an issue for me.
So I think I'll just revert my commit for hiding the docker's title for now.

timotheegiet added a comment.Mar 10 2021, 12:42 PM

Also, I agree with @mwein about the tabs: better keep the text as it was before; having the begining cut just looks weird.

+ They now take quite more vertical space, which I believe is not very good.

timotheegiet added a comment.Mar 10 2021, 12:51 PM

+ same comment for the document tabs: I see that when there's more than one document open, the tabs get bigger height, which is a bit of vertical space waste.

tymond updated the task description. (Show Details)Mar 10 2021, 1:01 PM
tymond updated the task description. (Show Details)Mar 11 2021, 3:31 AM
timotheegiet added a comment.EditedMar 19 2021, 3:57 PM

Note about the "chains lock" images:

-The first version I made was looking like this:


(the chain is 2px wide)

Then after @tymond complained it was too big, I made it like this (which is how it is currently in master):


(the chain is 1px wide)
Then @tymond gave further explanations that her issue is not the image itself but the way it is wrongly scaled-up on her system. This issue is independant from the image itself, I guess it's caused because it's a kind of very custom button loading the images in a very specific way, and so it needs a fix to play nicely with global scaling.

Now, I just got a comment from deiflou on irc that they think the icon looks too small... So if people prefer the first version, I can just revert to it.
(note that in both versions, the gloabl size of the image/button is exactly the same as before)

EDIT: ok, actually deiflou's issue is also a weird scaling issue that just popped-up:


So I guess we can keep V2 images, but need to fix those weird scaling issues...

timotheegiet updated the task description. (Show Details)Mar 19 2021, 9:49 PM

Chains-lock button should be fixed now.