mwein (Mathias Wein)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jan 9 2020, 1:59 AM (220 w, 8 h)
Availability
Available

Recent Activity

Jan 4 2022

mwein added a comment to T13509: "Wide Gamut Color Selector" Docker.

I think we talked about moving the color history to Ko~/KisCanvasResourceProvider, but I haven't done that yet.

Jan 4 2022, 1:49 PM · Krita: Abyss
mwein updated the task description for T13509: "Wide Gamut Color Selector" Docker.
Jan 4 2022, 1:40 PM · Krita: Abyss

Dec 20 2021

mwein updated the task description for T13509: "Wide Gamut Color Selector" Docker.
Dec 20 2021, 3:22 AM · Krita: Abyss

Aug 20 2021

mwein added a comment to T14815: Single source of truth for Krita preferences.

I was also irritated by the use of "read only" KisConfig instances to manipulate settings, but to me it looks like that is a misleading parameter name. It often gets used as "I don't want you to auto-synchronize the config on destruction, because it will be done later anyway"...

Aug 20 2021, 2:54 AM · Krita

Mar 10 2021

mwein added a comment to T14188: Krita UI refresh spring 2021.

On another note, where did the titles go for the dockers? The titles for the dockers seem to all have disappeared. You can only see the title if they are in a tab now

Mar 10 2021, 7:15 AM · Krita: Abyss

Mar 9 2021

mwein added a comment to T14188: Krita UI refresh spring 2021.

Docker tabs don't really elide text in a useful way after commit bc233c344b4dcd1bb54d28af470399c3d37d2f69, and somehow the inactive tab corners seem to bend outwards.
With the (otherwise duplicated) docker title also removed, you have to rely on the tooltip to actually figure out the docker name.

Mar 9 2021, 10:23 PM · Krita: Abyss

Feb 5 2021

mwein added a comment to T13509: "Wide Gamut Color Selector" Docker.

I think I caught all regressions from porting to master (Krita 5.0), there had been one issue with Gamut Masks I didn't catch initially because it would just fail to connect signals/slots until the code was ported to shared pointers.

Feb 5 2021, 1:20 AM · Krita: Abyss
mwein updated the task description for T13509: "Wide Gamut Color Selector" Docker.
Feb 5 2021, 12:54 AM · Krita: Abyss

Jan 21 2021

mwein added an inline comment to M168: Resource Manager Mockup.

I tried to implement the mockup as actual dialog, and I think I understand how most of it should work, except for the (Un)delete button.

Jan 21 2021, 11:23 PM · Krita: Abyss

Jan 11 2021

mwein added a comment to T13509: "Wide Gamut Color Selector" Docker.

The last point is about the toggle in the docker to choose between foreground or background modification (the Advanced Color Selector has no explicit setting, it is right mouse button for that).

Jan 11 2021, 12:39 PM · Krita: Abyss
mwein added a comment to T13509: "Wide Gamut Color Selector" Docker.

Time for some new pictures...
So for the selector choice, I settled with a slim bar with the theme's highlight color to indicate the currently selected one. With the default dark theme it is rather subtle though, not sure what you think:

Jan 11 2021, 10:51 AM · Krita: Abyss

Jan 2 2021

mwein updated the task description for T13509: "Wide Gamut Color Selector" Docker.
Jan 2 2021, 11:56 PM · Krita: Abyss

Oct 26 2020

mwein added a comment to T13509: "Wide Gamut Color Selector" Docker.

Finally, all settings except the colorspace option are hooked up in the settings dialog, now the shade selector can finally be configured.

Oct 26 2020, 2:36 PM · Krita: Abyss

Oct 2 2020

mwein added a comment to T13556: Updating libheif.

Where are you stuck with AVIF loading?
I was at first clueless why adding the .avif extension to plugins/impex/heif/krita_heif_import.json didn't work, until I found with some grep-fu that I first need to add it to libs/koplugin/KisMimeDatabase.cpp.
I'm just not sure about the actual MIME types, apparently there are separate types, image/heic == HEIF+HEVC and image/avif == HEIF+AV1, so I added it as new type, and could get Krita to load them.

Oct 2 2020, 3:44 PM · Krita: Abyss
mwein added a comment to T13678: Generalized "Pop-up Widget" Concept.

Since Wolthera added me as subscriber anyway, it just came to my mind again.

Oct 2 2020, 2:07 AM · Krita: Abyss

Sep 30 2020

mwein added a comment to T13556: Updating libheif.

Hm libheif is confusing me, libheif.h claims:

Sep 30 2020, 3:20 AM · Krita: Abyss

Sep 15 2020

mwein added a comment to T13509: "Wide Gamut Color Selector" Docker.

Some of the settings are now actually saved to kritarc, the selector can finally be configured independently of ACS (though it still can load the ACS settings, so outside this new docker it's still all the same)

Sep 15 2020, 8:06 PM · Krita: Abyss
mwein updated the task description for T13509: "Wide Gamut Color Selector" Docker.
Sep 15 2020, 7:06 PM · Krita: Abyss

Sep 2 2020

mwein added a comment to T13556: Updating libheif.

On sleeping on it, I may have overstated the scaling 10/12 to 16bit problem, scaling the values is fine, the problem is in particular, how do we know if a file needs to be interpreted as floating point, or as integer which in turn requires knowing if a file is HDR/Scene referred. We might indeed need to understand this from the associated colorspace or metadata.

Sep 2 2020, 9:17 PM · Krita: Abyss
mwein added a comment to T13556: Updating libheif.

I guess it wouldn't hurt to poke Daniel_a_Simona if there's any news on this:
https://krita-artists.org/t/allow-import-export-of-images-in-av1-image-file-format-avif/4626/8

Sep 2 2020, 1:42 AM · Krita: Abyss

Aug 31 2020

mwein added a comment to T13509: "Wide Gamut Color Selector" Docker.

I decided to try the split between color model handling and widget classes, but it was quite a bit more work that I thought. Main reason was that I needed to untangle the dependency on the ACS configuration, but that was on the todo list anyway.

Aug 31 2020, 10:45 PM · Krita: Abyss

Aug 20 2020

mwein added a comment to T13509: "Wide Gamut Color Selector" Docker.

I have a played a bit with KisGLImageWidget (messing with Small Color Selector basically) and Qt::WA_AlwaysStackOnTop attribute, but not extensively.
Stacking multiple partially transparent OpenGL widgets is probably just asking for trouble.

Aug 20 2020, 12:07 PM · Krita: Abyss

Aug 17 2020

mwein updated the task description for T13509: "Wide Gamut Color Selector" Docker.
Aug 17 2020, 12:00 PM · Krita: Abyss
mwein added a comment to T13509: "Wide Gamut Color Selector" Docker.

I am unsure about this, part of the current complexity of the config is because there's too many things to configure to begin with, and I feel this just shifts the complexity. I think this would require a bit more user-feedback, because... well, how often do you change these shapes?

Aug 17 2020, 11:56 AM · Krita: Abyss
mwein created T13509: "Wide Gamut Color Selector" Docker.
Aug 17 2020, 7:53 AM · Krita: Abyss

Jul 14 2020

mwein added a comment to T13380: Refresh of the Painting Assistant Tool and Painting Assistants.
  • Assistants can only be selected by clicking one of their handles, if the user accidentally click-drags, they can just undo it
  • Only show widget for currently selected assistant
Jul 14 2020, 1:57 AM · Krita: Abyss

Jun 28 2020

mwein committed R37:aeed48323c83: Move disconnection from display renderer where it belongs to (authored by mwein).
Move disconnection from display renderer where it belongs to
Jun 28 2020, 11:44 PM
mwein committed R37:c44371edd64b: Cleanup includes for KisVisualColorSelector sources (authored by mwein).
Cleanup includes for KisVisualColorSelector sources
Jun 28 2020, 11:44 PM
mwein committed R37:0127fd804bc8: Move disconnection from display renderer where it belongs to (authored by mwein).
Move disconnection from display renderer where it belongs to
Jun 28 2020, 11:43 PM
mwein committed R37:60194bfa43e0: Cleanup includes for KisVisualColorSelector sources (authored by mwein).
Cleanup includes for KisVisualColorSelector sources
Jun 28 2020, 11:43 PM

Jun 15 2020

mwein committed R37:00548c1d5649: <needs discussion> Remove IccColorProfile::Container class (authored by mwein).
<needs discussion> Remove IccColorProfile::Container class
Jun 15 2020, 8:51 PM
mwein committed R37:65232a425ad7: Add back reworked HDR handling to KisVisualColorSelector (authored by mwein).
Add back reworked HDR handling to KisVisualColorSelector
Jun 15 2020, 8:51 PM
mwein committed R37:c5dd68803892: Implement optimized renderBackground() for elliptical selector shape. (authored by mwein).
Implement optimized renderBackground() for elliptical selector shape.
Jun 15 2020, 8:51 PM
mwein committed R37:43e3137b5f25: Add new function to KoColorProfile to query if a profile's color space is… (authored by mwein).
Add new function to KoColorProfile to query if a profile's color space is…
Jun 15 2020, 8:51 PM
mwein committed R37:032bd82849ad: Break up KisVisualColorSelectorShape::getImageMap() (authored by mwein).
Break up KisVisualColorSelectorShape::getImageMap()
Jun 15 2020, 8:51 PM
mwein committed R37:81522cb6da55: Move setMask() calls from paintEvent() to resizeEvent(). (authored by mwein).
Move setMask() calls from paintEvent() to resizeEvent().
Jun 15 2020, 8:51 PM
mwein committed R37:8a00eaec2356: Don't call this->show() in a constructor. (authored by mwein).
Don't call this->show() in a constructor.
Jun 15 2020, 8:51 PM
mwein committed R37:a959eb9c3626: Finally realized why KisVisualRectangleShape behaves weird when non-square (authored by mwein).
Finally realized why KisVisualRectangleShape behaves weird when non-square
Jun 15 2020, 8:51 PM
mwein committed R37:e33a04af7075: Don't set a minimum height in color selector dialog UI file. (authored by mwein).
Don't set a minimum height in color selector dialog UI file.
Jun 15 2020, 8:51 PM
mwein committed R37:7badc858419e: Big KisVisualColorSelector refactor, Part 2 (removing code) (authored by mwein).
Big KisVisualColorSelector refactor, Part 2 (removing code)
Jun 15 2020, 8:50 PM
mwein committed R37:8e068259e53e: Flip y-coordinate in KisVisualRectangleShape, to match advanced color selector. (authored by mwein).
Flip y-coordinate in KisVisualRectangleShape, to match advanced color selector.
Jun 15 2020, 8:50 PM
mwein committed R37:63fdf4d9590d: (coding style) make some function const (authored by mwein).
(coding style) make some function const
Jun 15 2020, 8:50 PM
mwein committed R37:88d47933a7bb: Big KisVisualColorSelector refactor, Part 1 (adding code) (authored by mwein).
Big KisVisualColorSelector refactor, Part 1 (adding code)
Jun 15 2020, 8:50 PM
mwein committed R37:ec053a5e5a20: Don't allocate a QImage that should be overwritten anyway. (authored by mwein).
Don't allocate a QImage that should be overwritten anyway.
Jun 15 2020, 8:50 PM
mwein committed R37:b24087de3856: Fix widget->shape coordinate conversion of KisVisualEllipticalSelectorShape The… (authored by mwein).
Fix widget->shape coordinate conversion of KisVisualEllipticalSelectorShape The…
Jun 15 2020, 8:50 PM
mwein committed R37:d725866f0e9d: Correct size of memory allocation (authored by mwein).
Correct size of memory allocation
Jun 15 2020, 8:50 PM
mwein committed R37:57d6c876cf5b: Some signaling improvements in KisDlgInternalColorSelector: (authored by mwein).
Some signaling improvements in KisDlgInternalColorSelector:
Jun 15 2020, 8:50 PM
mwein committed R37:041737644b26: Allow KisVisualColorSelectorShape to handle coordinates outside of widget. (authored by mwein).
Allow KisVisualColorSelectorShape to handle coordinates outside of widget.
Jun 15 2020, 8:50 PM
mwein committed R37:fe8aae6a915a: Cleanup KisVisualColorSelector signaling a bit: (authored by mwein).
Cleanup KisVisualColorSelector signaling a bit:
Jun 15 2020, 8:50 PM
mwein committed R37:6be680ef7f71: KisVisualColorSelector layout improvements: (authored by mwein).
KisVisualColorSelector layout improvements:
Jun 15 2020, 8:50 PM
mwein committed R37:3c86b6cbc943: (cleanup) don't include compiled .ui file in header but only in source that… (authored by mwein).
(cleanup) don't include compiled .ui file in header but only in source that…
Jun 15 2020, 8:50 PM
mwein committed R37:721bd7d86cd4: <needs discussion> Remove IccColorProfile::Container class (authored by mwein).
<needs discussion> Remove IccColorProfile::Container class
Jun 15 2020, 8:50 PM
mwein committed R37:b03caacfb7a3: Add back reworked HDR handling to KisVisualColorSelector (authored by mwein).
Add back reworked HDR handling to KisVisualColorSelector
Jun 15 2020, 8:50 PM
mwein committed R37:56fa5532a4be: Add new function to KoColorProfile to query if a profile's color space is… (authored by mwein).
Add new function to KoColorProfile to query if a profile's color space is…
Jun 15 2020, 8:50 PM
mwein committed R37:b236fd53f378: Implement optimized renderBackground() for elliptical selector shape. (authored by mwein).
Implement optimized renderBackground() for elliptical selector shape.
Jun 15 2020, 8:50 PM
mwein committed R37:c342f8bd97b9: Move setMask() calls from paintEvent() to resizeEvent(). (authored by mwein).
Move setMask() calls from paintEvent() to resizeEvent().
Jun 15 2020, 8:50 PM
mwein committed R37:08a7033b8d43: Break up KisVisualColorSelectorShape::getImageMap() (authored by mwein).
Break up KisVisualColorSelectorShape::getImageMap()
Jun 15 2020, 8:50 PM
mwein committed R37:480f8d9d93f4: Don't call this->show() in a constructor. (authored by mwein).
Don't call this->show() in a constructor.
Jun 15 2020, 8:50 PM
mwein committed R37:5d80c39ce600: Don't set a minimum height in color selector dialog UI file. (authored by mwein).
Don't set a minimum height in color selector dialog UI file.
Jun 15 2020, 8:50 PM
mwein committed R37:d515213c1bc2: Finally realized why KisVisualRectangleShape behaves weird when non-square (authored by mwein).
Finally realized why KisVisualRectangleShape behaves weird when non-square
Jun 15 2020, 8:50 PM
mwein committed R37:3efc3c17e093: Flip y-coordinate in KisVisualRectangleShape, to match advanced color selector. (authored by mwein).
Flip y-coordinate in KisVisualRectangleShape, to match advanced color selector.
Jun 15 2020, 8:50 PM
mwein committed R37:033893eaa100: Big KisVisualColorSelector refactor, Part 2 (removing code) (authored by mwein).
Big KisVisualColorSelector refactor, Part 2 (removing code)
Jun 15 2020, 8:50 PM
mwein committed R37:7bd37aa8cdf0: Big KisVisualColorSelector refactor, Part 1 (adding code) (authored by mwein).
Big KisVisualColorSelector refactor, Part 1 (adding code)
Jun 15 2020, 8:50 PM
mwein committed R37:2fc8fe45d7f5: (coding style) make some function const (authored by mwein).
(coding style) make some function const
Jun 15 2020, 8:50 PM
mwein committed R37:a2555505ba86: Fix widget->shape coordinate conversion of KisVisualEllipticalSelectorShape The… (authored by mwein).
Fix widget->shape coordinate conversion of KisVisualEllipticalSelectorShape The…
Jun 15 2020, 8:50 PM
mwein committed R37:4e287d79e0de: Don't allocate a QImage that should be overwritten anyway. (authored by mwein).
Don't allocate a QImage that should be overwritten anyway.
Jun 15 2020, 8:50 PM
mwein committed R37:aa5cd5c0f356: Correct size of memory allocation (authored by mwein).
Correct size of memory allocation
Jun 15 2020, 8:50 PM
mwein committed R37:ea2eb601613c: Allow KisVisualColorSelectorShape to handle coordinates outside of widget. (authored by mwein).
Allow KisVisualColorSelectorShape to handle coordinates outside of widget.
Jun 15 2020, 8:50 PM
mwein committed R37:d53e07b37299: Some signaling improvements in KisDlgInternalColorSelector: (authored by mwein).
Some signaling improvements in KisDlgInternalColorSelector:
Jun 15 2020, 8:50 PM
mwein committed R37:75fc9db6bd63: Cleanup KisVisualColorSelector signaling a bit: (authored by mwein).
Cleanup KisVisualColorSelector signaling a bit:
Jun 15 2020, 8:50 PM
mwein committed R37:57b7cf7f9684: KisVisualColorSelector layout improvements: (authored by mwein).
KisVisualColorSelector layout improvements:
Jun 15 2020, 8:50 PM
mwein committed R37:ac7e10b4c98c: (cleanup) don't include compiled .ui file in header but only in source that… (authored by mwein).
(cleanup) don't include compiled .ui file in header but only in source that…
Jun 15 2020, 8:50 PM
mwein committed R37:506225476688: <needs discussion> Remove IccColorProfile::Container class (authored by mwein).
<needs discussion> Remove IccColorProfile::Container class
Jun 15 2020, 8:50 PM
mwein committed R37:112bd9262724: Add back reworked HDR handling to KisVisualColorSelector (authored by mwein).
Add back reworked HDR handling to KisVisualColorSelector
Jun 15 2020, 8:50 PM
mwein committed R37:b2b6a117cb63: Add isLinear() query function to KoColorProfile (authored by mwein).
Add isLinear() query function to KoColorProfile
Jun 15 2020, 8:50 PM
mwein committed R37:e3c4b1df6e6b: Break up KisVisualColorSelectorShape::getImageMap() (authored by mwein).
Break up KisVisualColorSelectorShape::getImageMap()
Jun 15 2020, 8:50 PM
mwein committed R37:7e338d37d6cc: Implement optimized renderBackground() for elliptical selector shape (authored by mwein).
Implement optimized renderBackground() for elliptical selector shape
Jun 15 2020, 8:50 PM
mwein committed R37:aac101eb00b0: Move setMask() calls from paintEvent() to resizeEvent() (authored by mwein).
Move setMask() calls from paintEvent() to resizeEvent()
Jun 15 2020, 8:50 PM
mwein committed R37:d7cdcb0f445b: Don't set a minimum height in color selector dialog UI file. (authored by mwein).
Don't set a minimum height in color selector dialog UI file.
Jun 15 2020, 8:50 PM
mwein committed R37:9932f751bef1: Don't call this->show() in a constructor (authored by mwein).
Don't call this->show() in a constructor
Jun 15 2020, 8:50 PM
mwein committed R37:f94069399fd3: Finally realized why KisVisualRectangleShape behaves weird when non-square (authored by mwein).
Finally realized why KisVisualRectangleShape behaves weird when non-square
Jun 15 2020, 8:50 PM
mwein committed R37:23d86926c787: Big KisVisualColorSelector refactor, Part 2 (removing code) (authored by mwein).
Big KisVisualColorSelector refactor, Part 2 (removing code)
Jun 15 2020, 8:50 PM
mwein committed R37:a33bb67affc1: Flip y-coordinate in KisVisualRectangleShape (authored by mwein).
Flip y-coordinate in KisVisualRectangleShape
Jun 15 2020, 8:50 PM
mwein committed R37:2d165e341e86: Big KisVisualColorSelector refactor, Part 1 (adding code) (authored by mwein).
Big KisVisualColorSelector refactor, Part 1 (adding code)
Jun 15 2020, 8:50 PM
mwein committed R37:a66d7717cebf: Fix widget->shape coordinate conversion of ellipse shape (authored by mwein).
Fix widget->shape coordinate conversion of ellipse shape
Jun 15 2020, 8:50 PM
mwein committed R37:98926f0fdedc: (coding style) make some function const (authored by mwein).
(coding style) make some function const
Jun 15 2020, 8:50 PM
mwein committed R37:8922da57f996: Don't allocate a QImage that should be overwritten anyway (authored by mwein).
Don't allocate a QImage that should be overwritten anyway
Jun 15 2020, 8:50 PM
mwein committed R37:70eb8c79616b: Correct size of memory allocation (authored by mwein).
Correct size of memory allocation
Jun 15 2020, 8:50 PM
mwein committed R37:3a5863119008: Some signaling improvements in KisDlgInternalColorSelector: (authored by mwein).
Some signaling improvements in KisDlgInternalColorSelector:
Jun 15 2020, 8:50 PM
mwein committed R37:b20df94a785b: Handle coordinates outside of rectangle selector shape (authored by mwein).
Handle coordinates outside of rectangle selector shape
Jun 15 2020, 8:50 PM
mwein committed R37:b7f8422d0a88: Cleanup KisVisualColorSelector signaling a bit: (authored by mwein).
Cleanup KisVisualColorSelector signaling a bit:
Jun 15 2020, 8:50 PM
mwein committed R37:d39e69ae8da2: (cleanup) Move .ui derived include from header to source (authored by mwein).
(cleanup) Move .ui derived include from header to source
Jun 15 2020, 8:50 PM
mwein committed R37:85937351b0de: KisVisualColorSelector layout improvements: (authored by mwein).
KisVisualColorSelector layout improvements:
Jun 15 2020, 8:50 PM
mwein committed R37:5f6370e22a3d: Merge branch 'lynx-color-sel' into 'master' (authored by mwein).
Merge branch 'lynx-color-sel' into 'master'
Jun 15 2020, 8:50 PM
mwein committed R37:c1d0f5584e66: Include reference images in screen color picker (authored by mwein).
Include reference images in screen color picker
Jun 15 2020, 8:50 PM
mwein committed R37:b48b8fc74303: Merge branch 'screen-color-picker-bug-411816' into 'master' (authored by mwein).
Merge branch 'screen-color-picker-bug-411816' into 'master'
Jun 15 2020, 8:50 PM
mwein committed R37:a7d8ba63751a: Fix loading of reference image settings (authored by mwein).
Fix loading of reference image settings
Jun 15 2020, 8:50 PM
mwein committed R37:d09a952f11c0: Merge branch 'reference-image-bug' into 'master' (authored by mwein).
Merge branch 'reference-image-bug' into 'master'
Jun 15 2020, 8:49 PM
mwein committed R37:c384f41f1b4e: Merge branch 'kocolor-bug' into 'master' (authored by mwein).
Merge branch 'kocolor-bug' into 'master'
Jun 15 2020, 8:49 PM
mwein committed R37:8fd9758d8216: Merge branch 'export_settings' into 'master' (authored by mwein).
Merge branch 'export_settings' into 'master'
Jun 15 2020, 8:48 PM