User Details
- User Since
- Jan 9 2020, 1:59 AM (220 w, 8 h)
- Availability
- Available
Jan 4 2022
I think we talked about moving the color history to Ko~/KisCanvasResourceProvider, but I haven't done that yet.
Dec 20 2021
Aug 20 2021
I was also irritated by the use of "read only" KisConfig instances to manipulate settings, but to me it looks like that is a misleading parameter name. It often gets used as "I don't want you to auto-synchronize the config on destruction, because it will be done later anyway"...
Mar 10 2021
Mar 9 2021
Docker tabs don't really elide text in a useful way after commit bc233c344b4dcd1bb54d28af470399c3d37d2f69, and somehow the inactive tab corners seem to bend outwards.
With the (otherwise duplicated) docker title also removed, you have to rely on the tooltip to actually figure out the docker name.
Feb 5 2021
I think I caught all regressions from porting to master (Krita 5.0), there had been one issue with Gamut Masks I didn't catch initially because it would just fail to connect signals/slots until the code was ported to shared pointers.
Jan 21 2021
I tried to implement the mockup as actual dialog, and I think I understand how most of it should work, except for the (Un)delete button.
Jan 11 2021
The last point is about the toggle in the docker to choose between foreground or background modification (the Advanced Color Selector has no explicit setting, it is right mouse button for that).
Time for some new pictures...
So for the selector choice, I settled with a slim bar with the theme's highlight color to indicate the currently selected one. With the default dark theme it is rather subtle though, not sure what you think:
Jan 2 2021
Oct 26 2020
Finally, all settings except the colorspace option are hooked up in the settings dialog, now the shade selector can finally be configured.
Oct 2 2020
Where are you stuck with AVIF loading?
I was at first clueless why adding the .avif extension to plugins/impex/heif/krita_heif_import.json didn't work, until I found with some grep-fu that I first need to add it to libs/koplugin/KisMimeDatabase.cpp.
I'm just not sure about the actual MIME types, apparently there are separate types, image/heic == HEIF+HEVC and image/avif == HEIF+AV1, so I added it as new type, and could get Krita to load them.
Since Wolthera added me as subscriber anyway, it just came to my mind again.
Sep 30 2020
Hm libheif is confusing me, libheif.h claims:
Sep 15 2020
Some of the settings are now actually saved to kritarc, the selector can finally be configured independently of ACS (though it still can load the ACS settings, so outside this new docker it's still all the same)
Sep 2 2020
On sleeping on it, I may have overstated the scaling 10/12 to 16bit problem, scaling the values is fine, the problem is in particular, how do we know if a file needs to be interpreted as floating point, or as integer which in turn requires knowing if a file is HDR/Scene referred. We might indeed need to understand this from the associated colorspace or metadata.
I guess it wouldn't hurt to poke Daniel_a_Simona if there's any news on this:
https://krita-artists.org/t/allow-import-export-of-images-in-av1-image-file-format-avif/4626/8
Aug 31 2020
I decided to try the split between color model handling and widget classes, but it was quite a bit more work that I thought. Main reason was that I needed to untangle the dependency on the ACS configuration, but that was on the todo list anyway.
Aug 20 2020
I have a played a bit with KisGLImageWidget (messing with Small Color Selector basically) and Qt::WA_AlwaysStackOnTop attribute, but not extensively.
Stacking multiple partially transparent OpenGL widgets is probably just asking for trouble.
Aug 17 2020
I am unsure about this, part of the current complexity of the config is because there's too many things to configure to begin with, and I feel this just shifts the complexity. I think this would require a bit more user-feedback, because... well, how often do you change these shapes?
Jul 14 2020
- Assistants can only be selected by clicking one of their handles, if the user accidentally click-drags, they can just undo it
- Only show widget for currently selected assistant