ffmpegextractor: Silence deprecation warnings
Concern Raised037208a787e0

Authored by michaelh on Apr 11 2018, 11:51 AM.

Description

ffmpegextractor: Silence deprecation warnings

Test Plan: make

Reviewers: Baloo, Frameworks, mgallien

Reviewed By: Baloo, mgallien

Subscribers: mgallien, bruns

Tags: Frameworks, Baloo

Differential Revision: https://phabricator.kde.org/D12108

Details

Auditors
kfunk
Committed
michaelhApr 19 2018, 11:42 AM
Reviewer
Baloo
Differential Revision
D12108: ffmpegextractor: Silence deprecation warnings
Parents
R286:8b8857cb6bc3: autotests: Do not use QScopedPointer for plugins
Branches
Unknown
Tags
Unknown
kfunk raised a concern with this commit.Apr 26 2018, 6:31 AM
kfunk added subscribers: jriddell, kfunk.

Concern by @jriddell on kde-frameworks ML:

kfilemetadata does not compile in KDE neon from git master currently

/workspace/build/src/extractors/ffmpegextractor.cpp:97:15: error:
‘AVCodecParameters’ does not name a type
12:27:35          const AVCodecParameters* codec = stream->codecpar;

https://build.neon.kde.org/job/xenial_unstable_kde_kfilemetadata_bin_amd64/145/console

It may be expecting a newer version of ffmpeg

Jonathan

This commit now has outstanding concerns.Apr 26 2018, 6:31 AM