Wrapped output messages of 'balooctl status ...' in i18n*
Sent error messages to stderr
Details
- Reviewers
vhanda smithjd lueck lbeltrame - Group Reviewers
Frameworks - Commits
- R293:e733c7f72695: balooctl status: translatable message
compile & run
Diff Detail
- Repository
- R293 Baloo
- Branch
- ctl
- Lint
No Linters Available - Unit
No Unit Test Coverage
src/tools/balooctl/statuscommand.cpp | ||
---|---|---|
108 | Question: Is this ever going to be translated? |
src/tools/balooctl/statuscommand.cpp | ||
---|---|---|
108 | german translator here: |
src/tools/balooctl/statuscommand.cpp | ||
---|---|---|
108 | I see. Thank you for the info. out << i18n("Basic indexing") << " " <<i18n("done"); |
src/tools/balooctl/statuscommand.cpp | ||
---|---|---|
108 | No. Please have a look at https://api.kde.org/frameworks/ki18n/html/prg_guide.html |
src/tools/balooctl/statuscommand.cpp | ||
---|---|---|
108 |
"File: %1"will be translated e.g. in german to "Datei: %1" and at runtime %1 is replaced by the string value of filePath
Please no, word puzzles are evil for translators |
src/tools/balooctl/statuscommand.cpp | ||
---|---|---|
108 | Just installed baloo5-lang. Now I see the difference |
src/tools/balooctl/statuscommand.cpp | ||
---|---|---|
111 | If we want output of balooctl status <path> to be parseable, then IMO it shouldn't be translated. |
May I observe that relying on the command line output is fragile in the best case?
Unless the command can produce the output in some formatted way (like the openstack CLI, which can enable a special mode to produce output in various formats like csv, table-formatted, or direct values, and select the columns).
I agree. Having a special mode which gives json/csv or some other machine readable output is a far better option.
Reverted parseablity in preparation for a --format switch
Sending error messages to stderr
i18n'ed all messages
src/tools/balooctl/statuscommand.cpp | ||
---|---|---|
108–125 ↗ | (On Diff #24888) | <filename> ... overkill? |