Port kprinter4 to Qt 5/KDE 5
AbandonedPublic
Actions

Authored by michaelweghorn on Dec 15 2017, 6:48 AM.

Details

Reviewers

None

Group Reviewers

Summary

This ports kprinter4 to use KDE 5/Qt 5, in particular
the Qt 5 print dialog.
Functionality is basically unchanged (except for
differences in the underlying Qt 4 vs. Qt 5 print dialog).

The migration is actually a series of git commits, and is
also available in the branch "michaelweghorn/qt5Port",
currently in a fork of the repository in Gitlab:
https://gitlab.com/michaelweghorn/kprinter4/tree/michaelweghorn/qt5Port

In addition, a .arcconfig is added to have a proper setup for using the
"arc" command line tool to interact with Phabricator.

Test Plan

Open a PostScript file with kprinter4.
Verify that the Qt 5 print dialog is being used.
Check that functionality is basically the same as before the port to Qt 5/KDE 5.

Diff Detail

Repository

R757 KPrinter for KDE 4

Branch

update_phabricator

Lint

No Linters Available

Unit

No Unit Test Coverage

michaelweghorn requested review of this revision.Dec 15 2017, 6:48 AM

michaelweghorn created this revision.

anthonyfieroni added a reviewer: KDE Applications.Dec 15 2017, 7:55 AM

anthonyfieroni added a subscriber: anthonyfieroni.

anthonyfieroni added inline comments.

CMakeLists.txt
57–58	Let's call it kprinter5.
main.cpp
33	Use capital letters include KLocalizedString

Rename to "kprinter5", update includes

Change the application name to "kprinter5"
Update includes: "klocalizedstring.h" -> "KLocalizedString"
Update POT file and German translation after renaming the application

The 2 suggested improvements are now implemented.

Is this still relevant?

In D9341#479680, @ngraham wrote:

Is this still relevant?

Good question...
Since distributions are dropping Qt 4, porting to qt5/kf5 seems the only way to keep kprinter alive. On the other hand, it seems to have been inactive for quite a while already and I'm not sure how big the need for kprinter actually still is.
There's e.g. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=874973 where this qt5 port was added for the Debian package in form of patches ~1 year ago, but there doesn't seem to be much interest and it never made it into the official Debian package.
If not considered relevant any more, an alternative might be to abandon kprinter after all? Probably Okular can be used as a replacement for those that want to print PostScript files using the Qt print dialog, in particular with the --print-and-exit option it gained in the meanwhile (though it doesn't yet have all options for scaling or poster printing that kprinter has).

Long time ago the choice was to drop the printing function from the code managed by KDE and use whatever was provided by Qt. If I remember correctly (@aacid probably remembers the story more than me) the original promise of having more care from the Qt side didn't exactly work as expected, so we had a lot of regression for a long time (until few people started pushing the feature again to Qt). At this point, kprinter is probably redundant and the missing features should be probably pushed to Qt. Or at least the features already provided by Qt should be removed from here.

kprinter maybe/probably/potentially does things that the qt print dialog doesn't, but yes, it'd be much better if those were upstreamed rather than having another tool you have to learn how to use besides the print dialog of apps

In D9341#482119, @aacid wrote:

kprinter maybe/probably/potentially does things that the qt print dialog doesn't, but yes, it'd be much better if those were upstreamed rather than having another tool you have to learn how to use besides the print dialog of apps

kprinter actually uses the Qt print dialog and just adds some specific tabs. I agree that functionality should best be upstreamed to Qt, though implementing it in a general and platform-independent way is certainly much more work than using existing command-line tools to handle PostScript, which, IIRC is what kprinter mostly does.

Anyway, abandoning this patch now; there doesn't seem to be much interest in kprinter any longer and I personally don't care much.

Revision Contents
Changeset List

			Path
A	M		.arcconfig (3 lines)
M			CMakeLists.txt (53 lines)
M			Messages.sh (4 lines)
M			README.md (12 lines)
M			config.h.cmake (2 lines)
M			fileprinter.h (16 lines)
M			fileprinter.cpp (75 lines)
V		(img)	icons/{128-apps-kprinter5.png ← hi128-app-kprinter4.png}
V		(img)	icons/{16-apps-kprinter5.png ← hi16-app-kprinter4.png}
V		(img)	icons/{32-apps-kprinter5.png ← hi32-app-kprinter4.png}
V		(img)	icons/{48-apps-kprinter5.png ← hi48-app-kprinter4.png}
V		(img)	icons/{64-apps-kprinter5.png ← hi64-app-kprinter4.png}
M			icons/CMakeLists.txt (5 lines)
V		(img)	icons/{hi128-app-kprinter4.png → 128-apps-kprinter5.png}
V		(img)	icons/{hi16-app-kprinter4.png → 16-apps-kprinter5.png}
V		(img)	icons/{hi32-app-kprinter4.png → 32-apps-kprinter5.png}
V		(img)	icons/{hi48-app-kprinter4.png → 48-apps-kprinter5.png}
V		(img)	icons/{hi64-app-kprinter4.png → 64-apps-kprinter5.png}
V			{kprinter4.desktop → kprinter5.desktop}
V			{kprinter5.desktop ← kprinter4.desktop} (10 lines)
M			main.cpp (150 lines)
M			po/CMakeLists.txt (2 lines)
M			po/de.po (106 lines)
V			po/{kprinter4.pot → kprinter5.pot}
V			po/{kprinter5.pot ← kprinter4.pot} (329 lines)
M			postscriptdocument.h (3 lines)
M			postscriptdocument.cpp (38 lines)
M			utils/papersizeutils.h (4 lines)
M			utils/papersizeutils.cpp (3 lines)
M			utils/tmpdir.h (3 lines)
M			utils/tmpdir.cpp (23 lines)
M			widgets/posterpreview.h (5 lines)
M			widgets/posterpreview.cpp (2 lines)
M			widgets/posterwidget.h (5 lines)
M			widgets/posterwidget.cpp (25 lines)
M			widgets/printscalingoptionswidget.h (5 lines)
M			widgets/printscalingoptionswidget.cpp (4 lines)
M			widgets/printscalingoptionswidgetUI.ui (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	23947	eb67ab9		Dec 15 2017, 6:48 AM	★	★
Diff 2	23949	eb67ab9	Rename to "kprinter5", update includes	Dec 15 2017, 8:51 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
0b842c0883cc	1b1da0b65a93	a65cdbc4dd41	Michael Weghorn	Port kprinter4 to Qt 5/KDE 5 (Show More…)	Dec 15 2017, 6:37 AM
a65cdbc4dd41	1b1da0b65a93	2c59ff46b10a	Michael Weghorn	Update include: "klocalizedstring.h" -> "KLocalizedString"	Dec 15 2017, 8:26 AM
2c59ff46b10a	f4b18a460d3c	c7d69eb3d3a9	Michael Weghorn	Update POT and German translation after renaming app to kprinter5	Dec 15 2017, 8:21 AM
c7d69eb3d3a9	5200c7a0cbbc	ada61a43a8c7	Michael Weghorn	Change application name to "kprinter5"	Dec 15 2017, 8:10 AM
ada61a43a8c7	5968024ba110	eaf0b8c9a4d7	Michael Weghorn	Add .arcconfig (Show More…)	Dec 15 2017, 6:37 AM
eaf0b8c9a4d7	ce24034016a1	c2a1dcbc833e	Michael Weghorn	Fix scope of temporary files (Show More…)	Dec 13 2017, 12:56 PM
c2a1dcbc833e	a9b9d0615c26	e7ede893b2ed	Michael Weghorn	Enable localization (Show More…)	Dec 13 2017, 10:27 AM
e7ede893b2ed	f07e6690d3d6	3fc03e643ef1	Michael Weghorn	CMakeLists.txt: Clean up list of needed components	Dec 13 2017, 7:24 AM
3fc03e643ef1	0d25b0a55fdb	50d81dd70e0f	Michael Weghorn	Fix: Add missing spaces in icons/CMakeLists.txt	Dec 12 2017, 6:28 PM
50d81dd70e0f	ef2cd8d09f0e	f13afe30c028	Michael Weghorn	Fix includes to avoid need for KDE 4 headers	Dec 12 2017, 6:25 PM
f13afe30c028	8f2d0fe763f4	cedca8e36e4c	Michael Weghorn	Update README	Dec 12 2017, 5:22 PM
cedca8e36e4c	1aa6a645b0e9	fba8359325ca	Michael Weghorn	Drop obsolete KDE 4 include dirs	Dec 12 2017, 5:10 PM
fba8359325ca	902422ccc901	bfa0f96297c8	Michael Weghorn	CMakeLists.txt: Drop KDELibs4Support, clean up	Dec 12 2017, 5:08 PM
bfa0f96297c8	56400551f5b8	dae493150201	Michael Weghorn	Drop obsolete includes from UI file	Dec 12 2017, 5:08 PM
dae493150201	89c2140fc649	2b3704aacbb5	Michael Weghorn	Remove now unused 'kdebug.h' include	Dec 12 2017, 5:01 PM
2b3704aacbb5	6802d8228cfd	9a09f6011c40	Michael Weghorn	kWarning -> qWarning	Dec 12 2017, 5:01 PM
9a09f6011c40	e2d4a76b25c9	1b3ce6b58812	Michael Weghorn	More 'kDebug' -> 'qDebug'	Dec 12 2017, 4:58 PM
1b3ce6b58812	80a038658fb9	c6d33df85a70	Michael Weghorn	Drop unused 'KConfigDialogManager* mConfigDialogManager'	Dec 12 2017, 4:49 PM
c6d33df85a70	02b6f42d3c7d	a255ef5bf89e	Michael Weghorn	Use QFileDialog instead of KFileDialog (Show More…)	Dec 12 2017, 4:45 PM
a255ef5bf89e	14aa9afcc3b4	ca35dc95a686	Michael Weghorn	KDebug -> QDebug; update various includes (Show More…)	Dec 12 2017, 4:31 PM
ca35dc95a686	309908d395a6	96b924065f36	Michael Weghorn	Avoid using KdePrint::createPrintDialog (Show More…)	Dec 12 2017, 4:09 PM
96b924065f36	442b28c76472	6a8afb8024ac	Michael Weghorn	Replace deprecated KPushButton with QPushButton	Dec 12 2017, 3:57 PM
6a8afb8024ac	0d8119ccbf33	00bbd0eb8ca1	Michael Weghorn	Replace deprecated KIntNumInput with QSpinBox (Show More…)	Dec 12 2017, 3:54 PM
00bbd0eb8ca1	820952860353	4b87a41a07d9	Michael Weghorn	Start updating cmake config, includes	Dec 12 2017, 3:43 PM
4b87a41a07d9	88a128867943	c16071126930	Michael Weghorn	kde4_install_icon -> ecm_install_icons (Show More…)	Dec 12 2017, 3:24 PM
c16071126930	f795d1797405	edaab9a60b17	Michael Weghorn	KDE 4 -> KDE 5: KStandardDirs -> QStandardPaths (Show More…)	Dec 12 2017, 2:57 PM
edaab9a60b17	a3ea4dcba396	5292b6f94a24	Michael Weghorn	KDE 4 -> KDE 5: KTemporaryFile -> QTemporaryFile (Show More…)	Dec 12 2017, 2:45 PM
5292b6f94a24	77c7dccb37c8	fa4d4eae0330	Michael Weghorn	cmake: kde4_add_ui_files -> qt5_wrap_ui (Show More…)	Dec 12 2017, 2:27 PM
fa4d4eae0330	01caaf977df1	3d0a30f32a96	Michael Weghorn	Explicitly set cmake_policy (Show More…)	Dec 12 2017, 2:23 PM
3d0a30f32a96	8442b947a944	bd7ba68d73c8	Michael Weghorn	CMakeLists:txt: Newer cmake, avoid kde4_add_executable (Show More…)	Dec 12 2017, 12:02 PM
bd7ba68d73c8	569c385fed2b	9fb27bb27924	Michael Weghorn	Fix logic with option for (not) showing dialog (Show More…)	Dec 12 2017, 11:55 AM
9fb27bb27924	28c5acd354bb	dc97aa60c3e5	Michael Weghorn	KDE 4 -> KDE 5: Use QUrl	Dec 12 2017, 11:55 AM
dc97aa60c3e5	99b639445e24	f85d2d27b2fc	Michael Weghorn	KDE 4 -> KDE 5: Port KCmdLineArgs to QCommandLineParser (Show More…)	Dec 12 2017, 11:55 AM
f85d2d27b2fc	efb0adc1dfc4	29de994f87be	Michael Weghorn	KDE 4 -> KDE 5: ki18n() -> i18n()	Dec 12 2017, 11:55 AM
29de994f87be	a78401747ae1	c100a967112c	Michael Weghorn	KDE 4 -> KDE 5: Port KAboutData::KAboutData	Dec 12 2017, 11:55 AM
c100a967112c	0a4b21ffbf05	e8e17b3bd753	Michael Weghorn	Qt 4 -> Qt 5: Remove case QPrinter::PostScriptFormat (Show More…)	Dec 12 2017, 11:55 AM
e8e17b3bd753	863f432c337b	66574e1ed42b	Michael Weghorn	Remove nonexistent include	Dec 12 2017, 11:55 AM
66574e1ed42b	80732cb90d30	abbe39cf0be4	Michael Weghorn	FALSE -> false, TRUE -> true	Dec 12 2017, 11:55 AM
abbe39cf0be4	3bf4ad3a6c9a	e269d23dfcbe	Michael Weghorn	Qt 4 -> Qt 5: Adapt some includes	Dec 12 2017, 11:54 AM
e269d23dfcbe	21baab1109e9	eb67ab9a8761	Michael Weghorn	CMakeLists.txt: Adapt for Qt 5/KDE 5 (Show More…)	Dec 12 2017, 11:54 AM

Port kprinter4 to Qt 5/KDE 5AbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 23949

.arcconfig

CMakeLists.txt

Messages.sh

README.md

config.h.cmake

fileprinter.h

fileprinter.cpp

icons/128-apps-kprinter5.png

icons/16-apps-kprinter5.png

icons/32-apps-kprinter5.png

icons/48-apps-kprinter5.png

icons/64-apps-kprinter5.png

icons/CMakeLists.txt

icons/hi128-app-kprinter4.png

icons/hi16-app-kprinter4.png

icons/hi32-app-kprinter4.png

icons/hi48-app-kprinter4.png

icons/hi64-app-kprinter4.png

kprinter4.desktop

kprinter5.desktop

main.cpp

po/CMakeLists.txt

po/de.po

po/kprinter4.pot

po/kprinter5.pot

postscriptdocument.h

postscriptdocument.cpp

utils/papersizeutils.h

utils/papersizeutils.cpp

utils/tmpdir.h

utils/tmpdir.cpp

widgets/posterpreview.h

widgets/posterpreview.cpp

widgets/posterwidget.h

widgets/posterwidget.cpp

widgets/printscalingoptionswidget.h

widgets/printscalingoptionswidget.cpp

widgets/printscalingoptionswidgetUI.ui

Port kprinter4 to Qt 5/KDE 5
AbandonedPublic
Actions

Revision Contents
Changeset List