src/filewidgets/kfileplacesmodel.h
67–75	This breaks ABI so it's not acceptable. Also how does this fix anything if the new alternativeApplicationName parameter is never passed in any of the existing constructors?

Avoid ABI break

renatoo edited the summary of this revision. (Show Details)Dec 14 2017, 4:58 PM

renatoo marked an inline comment as done.

renatoo added inline comments.

src/filewidgets/kfileplacesmodel.h
67–75	Ok I created a new constructor to avoid ABI break; In fact this does not fix anything this only create a functionally that will be used by #D9332 (dolphin) to load contents exclusive for contents panel, since it uses a different appName to store it.

mlaurent requested changes to this revision.Dec 14 2017, 5:04 PM

mlaurent added a subscriber: mlaurent.

mlaurent added inline comments.

autotests/kfileplacesmodeltest.cpp
1276	QUrl(QStringLiteral("search:/videos-alternative"))
src/filewidgets/kfileplacesmodel.h
67–75	Add a comment for kf6 //kf6 merge with above method

This revision now requires changes to proceed.Dec 14 2017, 5:04 PM

Added documention for the new constructor

mlaurent added inline comments.Dec 14 2017, 5:25 PM

src/filewidgets/kfileplacesmodel.h
72	5.42 and missing //kf6 comment

Added kf6 comments

renatoo marked 2 inline comments as done.Dec 14 2017, 5:35 PM

mlaurent accepted this revision.Dec 15 2017, 8:33 AM

This revision is now accepted and ready to land.Dec 15 2017, 8:33 AM

Not commited ?

elvisangelaccio added a subscriber: elvisangelaccio.Dec 23 2017, 11:38 AM

elvisangelaccio added inline comments.

autotests/kfileplacesmodeltest.cpp
145 ↗	(On Diff #23930)	`if (!currentModel)` ?
src/filewidgets/kfileplacesmodel.h
69 ↗	(On Diff #23930)	typo: an alternativeApplicationName
70 ↗	(On Diff #23930)	wording: "in addition to" sound better to me

Fixed typo

renatoo mentioned this in D9347: Ignore baloo urls created from new KIO model.Jan 2 2018, 5:39 PM

ngraham mentioned this in D9985: Fix place item edit after creation.Jan 20 2018, 3:28 PM

Is this commitable now?

Probably the @since needs updating

Updated @since tag

Looks like this revision and the two that depend on it have all been accepted and are ready to land!

Closed by commit R241:fc1f2fe296d6: Allow filter places based on alternative application name (authored by Renato Araujo Oliveira Filho <renato.araujo@kdab.com>). · Explain WhyJan 26 2018, 1:25 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			autotests/kfileplacesmodeltest.cpp (39 lines)
M			src/filewidgets/kfileplacesmodel.h (8 lines)
M			src/filewidgets/kfileplacesmodel.cpp (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	23920	6f2045a		Dec 14 2017, 3:42 PM	★	★
Diff 2	23922	6f2045a	Avoid ABI break	Dec 14 2017, 4:57 PM	★	★
Diff 3	23926	6f2045a	Added documention for the new constructor	Dec 14 2017, 5:13 PM	★	★
Diff 4	23930	6f2045a	Added kf6 comments	Dec 14 2017, 5:35 PM	★	★
Diff 5	24605	de5cc8b	Fixed typo	Jan 2 2018, 4:37 PM	★	★
Diff 6	25880	4642cf6	Updated @since tag	Jan 24 2018, 12:41 PM	★	★
Diff 7	25988	32b63b5	R241:fc1f2fe296d69d62f22e8794b7dc01f23d5aae14	Jan 26 2018, 1:25 PM	★	★

Allow filter places based on alternative application name
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 24605

autotests/kfileplacesmodeltest.cpp

src/filewidgets/kfileplacesmodel.h

src/filewidgets/kfileplacesmodel.cpp

Allow filter places based on alternative application nameClosedPublicActions