This reverts commits 04cc49c71bdb948e06ccae2d97d7cc1a1d2f62af as well
as the follow-up partial fix c32c8d002e1216373560c94738841a7a5e1b976b
The whole internal data sync'ing design of the KNewStuff core library
relies on EntryInternal instances explicitely sharing the data.
Changing only EntryInternal to implicitly shared data broke things.
And changed behaviour of that class also for any 3rd-party consumers.
BUG: 386156
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Quicker is better here, i think... Perhaps it is worth adding the documentation we discussed as well in this review? Thinking about making it easier to track the history and whatnot of what happened and why...
Myself I have no time left to invest into this. And would be happy to see at least the regression finally fixed, before slipping in yet another release in some days. Remember, this breaks core functionality of knewstuff across multiple applications (everywhere at least where files are uncompressed after the download). Rendering KNewStuff completely useless in those apps, and also making the apps themselves look bad and broken.
I would propose to have those improve the API documentation who introduced the regression. As they know best why they missed the bit about things being explicitly-shared by design.
Actually I am already a bit annoyed that I have to push for fixing a regression I did not introduce myself.