Differential D8698

Fix KProtocoInfoTest if krusader is installed
ClosedPublic
Actions

Authored by elvisangelaccio on Nov 7 2017, 4:05 PM.

Details

Reviewers
dfaure
davidedmundson
Commits
R241:50b944cd93fe: Fix KProtocoInfoTest if krusader is installed
Summary

Krusader has a krarc ioslave that handles zip files. If krusader is
installed, testProtocolForArchiveMimetype randomly fails depending on
the order the zip and krarc protocols are added to the cache.

This patch makes sure the test always passes.

Test Plan

Run kprotocolinfotest with krusader installed.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio created this revision.Nov 7 2017, 4:05 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 7 2017, 4:05 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
ngraham added a subscriber: ngraham.Nov 7 2017, 9:48 PM

Is the same problem present in the non-test code? I just noticed https://bugs.kde.org/show_bug.cgi?id=384991, which seems to report a similar or identical issue.

elvisangelaccio retitled this revision from Fix KProtolInfoTest if krusader is installed to Fix KProtocoInfoTest if krusader is installed.Nov 12 2017, 8:43 PM
elvisangelaccio added a comment.Nov 28 2017, 10:06 PM

Ping?

In D8698#165475, @ngraham wrote:

Is the same problem present in the non-test code? I just noticed https://bugs.kde.org/show_bug.cgi?id=384991, which seems to report a similar or identical issue.

I replied in the bug report, not related.

elvisangelaccio added a comment.Jan 3 2018, 11:38 AM

Ping? If there are no objections I'll land this before the next tagging.

davidedmundson accepted this revision.Jan 3 2018, 11:49 AM
This revision is now accepted and ready to land.Jan 3 2018, 11:49 AM
Closed by commit R241:50b944cd93fe: Fix KProtocoInfoTest if krusader is installed (authored by elvisangelaccio). · Explain WhyMay 7 2018, 8:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mautotests/kprotocolinfotest.cpp (2 lines)

Diff 33793

View Options

autotests/kprotocolinfotest.cpp

Loading...