Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN
1b35e76b8932
Actions

Authored by kossebau on Aug 15 2017, 2:43 AM.

Description

Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

Nested classes inherit the visibility of their outer class,
so all the KClass::Private symbols have also been exported
if the ones of KClass were.

Best fix would be to change all pimpl classes to be non-nested,
but that needs a bigger patch as some nested classes directly
access types and properties of their outer classes.
Left to do for the future :)

Details

Committed

kossebau

Nov 5 2017, 10:18 AM

Parents

R241:72c81e41aac1: Fix display of remote:/ in the qfiledialog

Branches

Unknown

Tags

Unknown

kossebau committed R241:1b35e76b8932: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN (authored by kossebau).Nov 5 2017, 10:18 AM

Changes (30)

				Path	Packages
	M			src/core/authinfo.cpp
	M			src/core/kacl.cpp
	M			src/core/kcoredirlister_p.h
	M			src/core/kdiskfreespaceinfo.cpp
	M			src/core/kmountpoint.cpp
	M			src/core/knfsshare.cpp
	M			src/core/ktcpsocket_p.h
	M			src/core/tcpslavebase.cpp
	M			src/filewidgets/kdiroperator.cpp
	M			src/filewidgets/kdirsortfilterproxymodel.cpp
	M			src/filewidgets/kfilefiltercombo.cpp
	M			src/filewidgets/kfileplacesmodel.cpp
	M			src/filewidgets/kfileplacesview.cpp
	M			src/filewidgets/kfilepreviewgenerator.cpp
	M			src/filewidgets/kimagefilepreview.cpp
	M			src/filewidgets/kpreviewwidgetbase.cpp
	M			src/filewidgets/kurlnavigator.cpp
	M			src/widgets/accessmanager.cpp
	M			src/widgets/fileundomanager.cpp
	M			src/widgets/jobuidelegate.cpp
	M			src/widgets/kdirlister.cpp
	M			src/widgets/kdynamicjobtracker.cpp
	M			src/widgets/kfileitemdelegate.cpp
	M			src/widgets/kpropertiesdialog.cpp
	M			src/widgets/krun_p.h
	M			src/widgets/ksslinfodialog.cpp
	M			src/widgets/kurifilter.cpp
	M			src/widgets/kurlrequester.cpp
	M			src/widgets/renamedialog.cpp
	M			src/widgets/thumbsequencecreator.cpp