| ngraham | |
| elvisangelaccio |
| Dolphin | |
| VDG |
This patch gives the status bar a little more vertical whitespace, prevents the status bar from "jumping up and down" when showing a progress bar, and adds a bit of padding on the sides so the labels are more clearly separated when using dual panes.
Screens
Full window:
Dual pane:
Progress bar (current & patched):
Try different settings and play around with it
| No Linters Available |
| No Unit Test Coverage |
From a visual perspective this to me is a perfect fix (cant comment on the technical details)
Looks good to me! There may be other areas where spacing is also necessary so this is going in a good direction.
Patch does not apply for me:
error: c/src/statusbar/dolphinstatusbar.cpp: No such file or directory
Could you upload it again?
Hey, thanks for the comments guys!
@elvisangelaccio My bad, I forgot to use --no-prefix. It's fixed now
You might want to look into using arc to upload and update patches. It takes a bit of time and effort to learn and set up, but then the workflow is so fast and easy.
Thanks for the tip. I had arc set up for Blender and thought setting for KDE would be a hassle. Turns out it was a single command heh
@januz, what is a good email address for you? I need that first before I can land this (commits must use real name + email address for the author field).
Diff is still wrong, it seems you have created it from within the src/ subfolder. You should do it from the top-level folder instead.
…or just use git diff (or git format-patch -1 in case you committed locally), so the directory won't matter.
Thanks, now it builds.
I'm afraid this change doesn't play well with non-breeze styles.
For example, with oxygen we go from
to
Also, the padding doesn't look good with the fusion style:
Thoughts from the VDG?
We could do without the extra padding on the sides for the sake of other styles. It's mostly a problem of rounded corners (IMO), it's hard to follow the alignment of the widgets below the panes.
As for the huge progress bars: I'm trying different values setFixedHeight() and setMaximumHeight() but it doesn't seem to follow them. Is there a way to control the height of the progress bar, or should I try wrapping it in a layout (and use margins to squash it)?
Forget what I said in the previous comment. I need a looooot of sleep :)
This version fixes the free space and connection progress bars for non-breeze styles
