FEATURE: 386261
By default, show "Downloaded From" information from files' extended attributes, if present. No change for files without the xattr.
broulik | |
dfaure | |
markg | |
vhanda |
Dolphin | |
Frameworks |
FEATURE: 386261
By default, show "Downloaded From" information from files' extended attributes, if present. No change for files without the xattr.
Tested in KDE Neon. Blew away dolphinrc and baloofileinformationrc, deployed the baloo-widgets change, rebuilt dolphin, downloaded a file using Chromium (which writes the user.xdg.origin.url xattr), opened Dolphin, navigated to the file, selected it, and turned on the Information panel. Downloaded From was visible. It was (correctly) not visible for any other file that lacked the user.xdg.origin.url xattr.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Looks good.
Maybe we should wait and see if someone who works on Dolphin has an opinion. This widget is only used in Dolphin.
Do any Dolphin people object? If not, I'll land this in a few days (sooner if I get some more thumbs up :) ).
Lovely! Less code, more features, those are the cool changes :)
I think it's safe to push.