Differential D8064

Correct installation of start_kdeinit when DESTDIR and libcap are used together
ClosedPublic
Actions

Authored by awilcox on Sep 30 2017, 3:48 AM.

Details

Reviewers
dfaure
Commits
R303:b82ea5b8d7b3: Correct installation of start_kdeinit when DESTDIR and libcap are used together
Summary

While packaging kinit 5.38.0 for Adélie, I ran in to the following error:

-- Installing: /usr/src/packages/user/kinit/pkg/kinit/usr/lib/libexec/kf5/start_kdeinit
Failed to set capabilities on file `/usr/lib/libexec/kf5/start_kdeinit' (No such file or directory)
usage: setcap [-q] [-v] (-r|-|<caps>) <filename> [ ... (-r|-|<capsN>) <filenameN> ]

 Note <filename> must be a regular (non-symlink) file.

This was caused by a missing escape in the CMake instruction to run setcap. I have verified that this patch also applies cleanly to master.

Test Plan
  • Build with and without libcap, with and without DESTDIR set.

Diff Detail

Repository
R303 KInit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
awilcox created this revision.Sep 30 2017, 3:48 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 30 2017, 3:48 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dfaure accepted this revision.Oct 7 2017, 6:57 PM

Strange syntax... but since you tested it ;-)

This revision is now accepted and ready to land.Oct 7 2017, 6:57 PM
graesslin added a subscriber: graesslin.Oct 10 2017, 5:51 PM

Do you have commit rights or should someone else push the patch? If the latter could you please upload a patch as a git formatted patch? I just tried to import this one and it fails due to no CMakeLists.txt.old in the repo.

awilcox updated this revision to Diff 20619.EditedOct 12 2017, 1:56 AM

This diff was created with git format-patch. I do not have commit rights.

Closed by commit R303:b82ea5b8d7b3: Correct installation of start_kdeinit when DESTDIR and libcap are used together (authored by graesslin). · Explain WhyOct 12 2017, 5:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/start_kdeinit/CMakeLists.txt (2 lines)

Diff 20654

View Options

src/start_kdeinit/CMakeLists.txt

Loading...