Differential D8029

Use edit-delete icon for destructive discard action
ClosedPublic
Actions

Authored by ngraham on Sep 28 2017, 1:09 PM.

Details

Reviewers
dfaure
rkflx
davidedmundson
cfeck
Group Reviewers
Frameworks
VDG
Commits
R236:6f30aad51452: Use edit-delete icon for destructive discard action
Summary

BUG: 385158

Use edit-delete icon for buttons that execute destructive discard actions. This is what Upstream Qt originally had, but we were overriding it to use a less-appropriate icon (edit-clear)

Test Plan

Tested in KDE Neon. An example of the change can be seen in Spectacle's main window:

Diff Detail

Repository
R236 KWidgetsAddons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Sep 28 2017, 1:09 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 28 2017, 1:09 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
ngraham edited the test plan for this revision. (Show Details)Sep 28 2017, 1:11 PM
ngraham added reviewers: Frameworks, VDG, dfaure, rkflx.
ngraham removed a project: Frameworks.
cfeck added a subscriber: cfeck.Sep 28 2017, 1:19 PM

Conflicts with D8024 which I had approved before I was aware of the bug report.

davidedmundson added a comment.Sep 28 2017, 3:08 PM

I think it's important that KStandardGuiItem::discard matches QDialogButtonBox::Discard

You've cited what Qt does, but we override it in kstyle.cpp:374 with dialog-cancel

If we go with this (and I really don't object) we should adjust KStyle too.

ngraham added a comment.Sep 28 2017, 3:25 PM

Submitted a patch for that, too: https://phabricator.kde.org/D8036

This revision is now accepted and ready to land.Sep 28 2017, 3:45 PM
ngraham closed this revision.Sep 28 2017, 4:44 PM

Revision Contents
Changeset List

PathPackages
Msrc/kstandardguiitem.cpp (2 lines)

Diff 20035

View Options

src/kstandardguiitem.cpp

Loading...