Differential D8024

Change icon for discard changes in a dialog to dialog-cancel
AbandonedPublic
Actions

Authored by davidedmundson on Sep 28 2017, 10:41 AM.

Details

Reviewers
cfeck
Summary

In frameworkintegration/src/kstyle/kstyle.cpp it is set to dialog-cancel
But here the standard item defaults to something else

BUG: 385158

Test Plan

Opened spectacle. Observed new icon

Diff Detail

Repository
R236 KWidgetsAddons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 28 2017, 10:41 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
cfeck accepted this revision.Sep 28 2017, 11:24 AM
This revision is now accepted and ready to land.Sep 28 2017, 11:24 AM
cfeck added a comment.Sep 28 2017, 1:05 PM

Hm, bug 385158 says we should use "edit-delete". Not sure who is right.

ngraham added a subscriber: ngraham.EditedSep 28 2017, 2:55 PM

Hmm, I think edit-delete is the correct icon here, for two reasons:

  1. That's what upstream Qt defaults to
  2. dialog-cancel is more appropriate for a Cancel button (in fact that's what cancel is already using). But Discard is a more destructive action than Cancel: "Cancel" involvs not doing something you were about to do, while, "Discard" involves throwing away something that already exists. Therefore, the red trash can icon from edit-delete is IMHO more appropriate, since its color and icon signal that it is a destructive operation.
davidedmundson abandoned this revision.Sep 28 2017, 2:57 PM

Edit. Didn't see that Ngraham had changed this also.

Revision Contents
Changeset List

PathPackages
Msrc/kstandardguiitem.cpp (2 lines)

Diff 20022

View Options

src/kstandardguiitem.cpp

Loading...