Differential D7769

[Task Manager] Use Grid for grouped and single tooltips
AbandonedPublic
Actions

Authored by romangg on Sep 11 2017, 4:49 PM.

Details

Reviewers
davidedmundson
hein
Group Reviewers
Plasma
Summary

This fixes the bug that the first tooltip shown after plasmashell launch is larger than needed. Also simplifies the code.

BUG: 382571

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
romangg created this revision.Sep 11 2017, 4:49 PM
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptSep 11 2017, 4:49 PM
romangg edited the summary of this revision. (Show Details)Sep 12 2017, 9:01 AM
davidedmundson added a subscriber: davidedmundson.Sep 12 2017, 9:09 AM
davidedmundson added inline comments.
applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
95

why did this move from here to the delegate?

romangg added inline comments.Sep 12 2017, 9:41 AM
applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
95

If it's not a grouped tooltip we still want to show the single ToolTipInstance in the Grid.

davidedmundson accepted this revision.Sep 12 2017, 9:41 AM
This revision is now accepted and ready to land.Sep 12 2017, 9:41 AM
hein accepted this revision.Sep 12 2017, 11:03 AM
cfeck added a subscriber: cfeck.Oct 5 2017, 12:29 AM

Please commit accepted changes.

romangg abandoned this revision.Nov 5 2018, 10:15 AM

Has been made unnecessary by 1e218b405bee.

Revision Contents
Changeset List

Diff 19409

View Options

applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

Loading...