[Task Manager] On containsMouse change always reset toolTipDelegate data
AbandonedPublic

Authored by romangg on Sep 11 2017, 3:56 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

Manually moving grouped tool tips together with single ones could mess up the mapping of their data. This patch makes sure that the correct information is provided by forcing reset of data on every containsMouse change.

Problem exemplified without patch: https://streamable.com/tcr9c

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
romangg created this revision.Sep 11 2017, 3:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptSep 11 2017, 3:56 PM
romangg edited the summary of this revision. (Show Details)Sep 11 2017, 3:58 PM

So now you copy to the data of toolTipDelegate.parentTask when the mouse leaves?
Why does that help?

hein added a subscriber: hein.Sep 12 2017, 11:04 AM

Yeah this one looks odd to me too as per David ...

So now you copy to the data of toolTipDelegate.parentTask when the mouse leaves?
Why does that help?

Good question. I don't understand how it helps, but it does. Somehow the model data needs to be copied an additional time to the delegate. It's something deeper probably, because without this patch (and only my other one) I even get seg faults when after I do manually change the task order I quickly raise another tooltip.

If you find a better solution, come forward. Otherwise I could also add a comment in the code explaining why we always copy the data.

What's next for this?

Thanks for the reminder. I have to understand the problem better first I believe. The others are right that my proposed solution is rather poor. As I said if somebody else can help me out here, this would be great. Otherwise I'll try to dissect the issue myself when I have time for it again (which could be after the release of 5.12). Since it's only a small glitch, it has low priority for me.

Thanks. I only bring this up because it's currently listed as a blocker for D7769, which as been accepted and was mentioned as a solution for a Task Manager bug (I'm screening all of them today).

romangg abandoned this revision.Nov 5 2018, 10:15 AM

Has been made unnecessary by 1e218b405bee.