Some parts of Elisa are unlocalizable now. This patch tries to fix this.
The patch was created by Victor <victorr2007@yandex.ru>
Details
Details
- Reviewers
mgallien - Group Reviewers
Elisa - Commits
- R255:64d1efa28aa1: Add localization to the local file KCM
Because of the oldish Qt (5.6.2) only extraction was tested on my machine.
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Thanks for your patch. I will test later but I have a question. Is the second extractor script really the way to go ? Is it not better to have everything in one ?
I will also check that the qml ui really gets translated.
Comment Actions
Sure, it can be squashed with the current Messages.sh file. It is just a matter of discussion what is the better way for Elisa team.
Comment Actions
I have no preference as long as it works and is similar to other kde software.
Thanks again for your help
Comment Actions
I was reading https://techbase.kde.org/Development/Tutorials/Localization/i18n_Build_Systems#Extracting_and_merging_messages about qml ui loaded via a package (kpackage). It seems the catalog should be called plasma_package_<catalog name>. Could you modify your patch according to this ?
I will test later today and report here (if nothing interrupt me).
Thanks again
Comment Actions
Trying to combine the proposals: remove separate translation catalog to avoid double extraction.
Must be horribly wrong because -DTRANSLATION_DOMAIN= is for libraries.
Comment Actions
I gave a look at the kcm in plasma-pa project. It is alos done with a qml UI.
The catalog should be named after the name of the desktop file of the kcm. If one does that, the translations are loaded in the qml UI files.
Could you modify your patch to generate a catalog specific to the kcm with the name kcm_elisa_local_file ?
Comment Actions
No changes to CMakeLists.txt (as it is expected to work as is), still double extraction (can be excluded with 'grep -v localFileConfiguration'-pipe in the main Messages.sh, but looks unpractical if further KCMs will be added).