Currently the test still passes even if one of the check_translations() calls fail.
The reason is that check_translations() is a function which has its own scope, so if it sets "failed" the upper level doesn't see it.
Use the PARENT_SCOPE option when setting the variable to properly propagate the value to the upper level.
Make a change so that the test is expected to fail, e.g. modify an expected output in tests/ECMPoQmToolsTest/check.cmake.in.
make test now will correctly mark the test as failed, before the test still passed.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
From the cmake documentation:
set(<variable> <value>... [PARENT_SCOPE])
Set the given `<variable>` in the current function or directory scope.
If the `PARENT_SCOPE` option is given the variable will be set in
the scope above the current scope. Each new directory or function
creates a new scope. This command will set the value of a variable
into the parent directory or calling function (whichever is applicable
to the case at hand).
| tests/ECMPoQmToolsTest/check.cmake.in | ||
|---|---|---|
| 79 | It should also change the other set(fail) calls. Or am I missing something? | |
| tests/ECMPoQmToolsTest/check.cmake.in | ||
|---|---|---|
| 79 | The other set(fail) calls *are* at the top-level and not inside a function. The function only goes from line#69 to #84. | |
Right, thanks. Your explanation + coffee helped.
Maybe a next iteration after merging this moving the function out of the if would be useful.