add a metainfo.yaml to make ECM a proper framework
ClosedPublic

Authored by sitter on Jul 10 2017, 9:49 AM.

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Jul 10 2017, 9:49 AM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptJul 10 2017, 9:49 AM
Restricted Application added subscribers: Build System, Frameworks. · View Herald Transcript

related to D6603

@ochurlaud I hope this will not break api.kde, given ECM hasn't had a metainfo.yaml previously it seems to have some sort of special arrangement?

ochurlaud edited edge metadata.Jul 10 2017, 3:05 PM

related to D6603

@ochurlaud I hope this will not break api.kde, given ECM hasn't had a metainfo.yaml previously it seems to have some sort of special arrangement?

No it has no reason to break.

Did you try it locally on ECM only (or better : ECM + kapidox) ?

Good point on trying it locally.

So, as one could expect this adds ECM as a product

Unfortunately given we have no actual documentation (outside the cmake documentation) this leads to a fairly useless page

Am I right in assuming that the way to fix this is to write a mainpage which links to https://api.kde.org/ecm/ for the actual cmake documentation?

dfaure edited edge metadata.Jul 11 2017, 3:23 PM

Please add a README.md too, with the same syntax as in the other frameworks.

ochurlaud added a comment.EditedJul 11 2017, 5:38 PM

At the time I thought about merging it but we would have to re-document everything in doxygen , which would be completely different from what upstream cmake does.

The ECM page is already linked from the left menu. Does it make sense to have it in frameworks? It's more a prerequisite for the framework no?

Anyway, a link would work though being suboptimal.

At the time I thought about merging it but we would have to re-document everything in doxygen , which would be completely different from what upstream cmake does.

The ECM page is already linked from the left menu. Does it make sense to have it in frameworks? It's more a prerequisite for the framework no?

Anyway, a link would work though being suboptimal.

The metainfo.yaml is a prerequisite for frameworks I think, yeah. If we could add a property to the yaml generateApiDox: false to prevent doxification of ECM that would also work all be it more work I suppose.

BUT
In a way, I am thinking that for consistency's sake it is actually nicer if ECM is listed alongside the other frameworks on https://api.kde.org/frameworks/index.html even if it then only links to the cmake documentation. It is, at the very least, more discoverable this way.

sitter updated this revision to Diff 16626.Jul 13 2017, 8:14 AM

add a readme

I've tried for like 2 hours to wire this into the existing docs
build and get away with one README. Alas, no luck.

dfaure accepted this revision.Jul 13 2017, 11:01 AM
This revision is now accepted and ready to land.Jul 13 2017, 11:01 AM
This revision was automatically updated to reflect the committed changes.