as per thread on frameworks-devel.
Also drop i18n.json as per other frameworks. i18n settings are inherited
from a base rule for all frameworks.
Details
Details
Diff Detail
Diff Detail
- Repository
- R247 Metadata for repositories
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Also see D6604 for proposed introduction of a metainfo.yaml to be consistent with other frameworks
Comment Actions
Please don't delete projects/kdesupport/extra-cmake-modules/i18n.json - this should be moved as well.
The i18n.json files go into the kde_projects.xml file which is used by scripty.
Aside from that, this patch looks fine. Please also ensure that the dependency data files in kde-build-metadata are also updated.
Comment Actions
For frameworks the i18n is entirely derived from the defaults file
So, this should be fine.
I did, however, forget to mention: the change effectively replaces trunk with trunk_kf5. Which is part of the motivation behind the move into frameworks, so ECM is fully aligned with the rest of frameworks WRT i18n.
Comment Actions
Assuming David is okay with ECM moving to Frameworks, this should be fine.
I have checked and it turns out other Frameworks don't have i18n.json files - I thought the tooling required one to be present, but if the others get away with not having one it should be fine.