Make sure that the tsfiles target is generated
ClosedPublic

Authored by apol on Jun 22 2017, 12:07 AM.

Details

Summary

I'm not sure how it's possible that pofiles is defined but tsfiles
isn't, but this does fix the issue reported by Luigi:
CMake Error at /usr/lib64/cmake/KF5I18n/KF5I18NMacros.cmake:129
(add_dependencies):

Cannot add target-level dependencies to non-existent target "tsfiles".
Test Plan

Built svn+ssh://svn@svn.kde.org/home/kde/trunk/l10n-kf5/fr by doing
./scripts/autogen.sh fr; mkdir build; cd build; cmake ../fr

Diff Detail

Repository
R249 KI18n
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Jun 22 2017, 12:07 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 22 2017, 12:07 AM
lueck edited edge metadata.Jun 22 2017, 3:09 AM

locale fr or uk build now, but without the script files beeing installed.
Looks like ./scripts/autogen.sh needs to be adapted as well

aacid requested changes to this revision.Jun 25 2017, 8:31 PM
aacid added a subscriber: aacid.
In D6331#118513, @lueck wrote:

locale fr or uk build now, but without the script files beeing installed.
Looks like ./scripts/autogen.sh needs to be adapted as well

No, scripts/autogen.sh doesn't need to be adapted, what Aleix needs to do is fix the regression he caused properly

This revision now requires changes to proceed.Jun 25 2017, 8:31 PM
apol updated this revision to Diff 16136.Jul 3 2017, 3:31 PM
apol edited edge metadata.
  • Restore the old behavior of KI18N_INSTALL_TS_FILES
ltoscano edited edge metadata.Jul 4 2017, 9:57 PM

It seems to work, just one question though:

cmake/KF5I18NMacros.cmake
178

Before this line, in the original version before the changes, there was this line:

string(REPLACE "@" "_" pmapc_target ${pmapc_target})

Could it be still relevant?

apol updated this revision to Diff 16202.Jul 5 2017, 12:36 PM
  • Restore the old behavior of KI18N_INSTALL_TS_FILES
  • Address luigi's comment
apol marked an inline comment as done.Jul 5 2017, 12:36 PM
apol added inline comments.
cmake/KF5I18NMacros.cmake
178

You are right, I must have copied a version that didn't have it yet. Fine by me, included.

ltoscano accepted this revision.Jul 5 2017, 2:15 PM

The issue initially reported is fixed. I tried with fr and other 3 languages which should be representative enough (de, uk, sr@ijekavian; the latter was complaining before the last revision of the review).

This revision was automatically updated to reflect the committed changes.
apol marked an inline comment as done.