Implement QPlatformTheme::fileIconPixmap() to make QFileIconProvider work.
Details
Diff Detail
- Repository
- R135 Integration for Qt applications in Plasma
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
It pains me a bit to say this since it looks like you've spend quite a bit of time writing that code.
But please do look at KIO::iconNameForUrl [1] (like also suggested by Kai on reviewboard). Much of the code can likely be replaced by just using that instead.
[1] https://api.kde.org/frameworks/kio/html/namespaceKIO.html#a215707adb0153b5ba4b318785fc746ea
It can't support QPlatformTheme::DontUseCustomDirectoryIcons flag, that is why I re-submitted here the same implementation.
I would rather not support DontUseCustomDirectoryIcons than reimplementing all of this logic :) Perhaps we could just special-case it for inode/directory to return a generic folder icon.
I would prefer if someone else ships it on your behalf, my setup is rather broken.
If nobody does it, i will somewhere next weekend.
In the future, please use arcanist to submit patches (or at least specify the repository).