eshalygin (Eugene Shalygin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 21 2017, 9:18 AM (117 w, 4 d)
Availability
Available

Recent Activity

Apr 23 2019

eshalygin added a comment to D20766: Use appropriate background color for text previews.

I would welcome the same palette in the file preview as the one I see in ktexteditor when open the file

Apr 23 2019, 2:06 PM · Frameworks, Dolphin
eshalygin updated the diff for D20766: Use appropriate background color for text previews.

Replace KColorScheme with QPalette

Apr 23 2019, 9:59 AM · Frameworks, Dolphin
eshalygin requested review of D20766: Use appropriate background color for text previews.
Apr 23 2019, 9:42 AM · Frameworks, Dolphin

Sep 14 2017

eshalygin added a comment to D7811: Put effectModelTest behind BUILD_TESTING conditional.

That doesn't work that well anymore since some version of cmake or Frameworks

Sep 14 2017, 6:18 PM · KWin

May 7 2017

eshalygin added a comment to D5538: Implement QPlatformTheme::fileIconPixmap().

Thanks a lot!

May 7 2017, 3:17 PM · Plasma
eshalygin updated the diff for D5538: Implement QPlatformTheme::fileIconPixmap().

Address review comments.

May 7 2017, 2:05 PM · Plasma

May 2 2017

eshalygin added a comment to D5538: Implement QPlatformTheme::fileIconPixmap().

Thanks!

May 2 2017, 8:46 PM · Plasma
eshalygin added a comment to D5538: Implement QPlatformTheme::fileIconPixmap().

ping?

May 2 2017, 5:44 PM · Plasma

May 1 2017

eshalygin added a comment to D5538: Implement QPlatformTheme::fileIconPixmap().

I don't have commit rights. Could someone commit this for me, please?

May 1 2017, 10:03 AM · Plasma

Apr 30 2017

eshalygin added a comment to D5538: Implement QPlatformTheme::fileIconPixmap().

Any news?

Apr 30 2017, 10:53 PM · Plasma

Apr 22 2017

eshalygin added a comment to D5538: Implement QPlatformTheme::fileIconPixmap().

@broulik ? What do you think about this implementation?

Apr 22 2017, 10:39 AM · Plasma

Apr 21 2017

eshalygin added a comment to D5538: Implement QPlatformTheme::fileIconPixmap().

Ready. Works.

Apr 21 2017, 3:01 PM · Plasma
eshalygin updated the diff for D5538: Implement QPlatformTheme::fileIconPixmap().

use QFileInfo::absoluteFilePath() always

Apr 21 2017, 3:01 PM · Plasma
eshalygin added a comment to D5538: Implement QPlatformTheme::fileIconPixmap().

Not ready yet.

Apr 21 2017, 2:59 PM · Plasma
eshalygin updated the diff for D5538: Implement QPlatformTheme::fileIconPixmap().

Fix a typo in function name

Apr 21 2017, 2:55 PM · Plasma
eshalygin updated the diff for D5538: Implement QPlatformTheme::fileIconPixmap().

OK, here is the updated patch that uses KIO::iconForURL()

Apr 21 2017, 2:47 PM · Plasma
eshalygin added a comment to D5538: Implement QPlatformTheme::fileIconPixmap().
In D5538#103838, @markg wrote:

But please do look at KIO::iconNameForUrl [1] (like also suggested by Kai on reviewboard). Much of the code can likely be replaced by just using that instead.

Apr 21 2017, 2:29 PM · Plasma
eshalygin created D5538: Implement QPlatformTheme::fileIconPixmap().
Apr 21 2017, 1:56 PM · Plasma