Use -Wno-gnu-zero-variadic-macro-arguments more
ClosedPublic
Actions

Authored by kfunk on Apr 4 2017, 5:40 PM.

Details

Reviewers

Commits

Summary

Add it to KDECompilerSettings.cmake instead of
KDEFrameworkCompilerSettings.cmake.

Users can then just enable -pedantic without worrying about this
particular the gnu-zero-variadic-macro-arguments warning.

This fixes some warnings in e.g. kdenlive

Repository

R240 Extra CMake Modules

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added subscribers: Build System, Frameworks. · View Herald Transcript

Re-enable for Clang

Which warnings? Are they proper warnings that should be fixed?

In D5302#99816, @apol wrote:

+1

Which warnings? Are they proper warnings that should be fixed?

See comment inside the source code: It's triggered by normal usage from qCDebug()...

This revision is now accepted and ready to land.Apr 5 2017, 10:28 AM

FYI: I'll wait with pushing until v5.33 is released.

5.33 is tagged since last saturday, you can push without waiting. It's always summer in master, for KF5.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kde-modules/KDECompilerSettings.cmake (6 lines)
M			kde-modules/KDEFrameworkCompilerSettings.cmake (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	13094	7af9f8e		Apr 4 2017, 5:40 PM	★	★
Diff 2	13096	47a4c06	Re-enable for Clang	Apr 4 2017, 6:20 PM	★	★
Diff 3	13113	47a4c06	R240:c20a9f69e8e2703cf42f320f26db122f3a6733df	Apr 5 2017, 12:52 PM	★	★