Some actions should not be started before all the previous actions
are finished. That is especially true for the actions that work
with layers stack, like "Merge Down" and "Flatten".
Now KisDelayedSaveDialog is used not only for saving, but also for
waiting before doing usual actions. It also has a busy-loop timeout of
1 second before showing up, for not distracting painters from their
workflow when the action is postponed only a little bit.
BUG:372724
Fixes T4593
Basically, the steps like in bug 372724.
There should be no crash, and the result should be somewhat expected.
Repeat the same for:
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
It may be safer, but I think that this isn't moving Krita in the right direction. Krita shouldn't bother the user with popups telling the user to wait until it's done, it should just do its job. We shouldn't be exposing the design faults of our code in this way.
Note: I'm fine with this for now, for safeties sake -- but I think we should sit down and solve this problem in a more fundamental way.
Well, I'm ok with discussing this stuff. But please note two points:
It seems to work for me, but I do get a lot of, when rapidly merging and undoing:
krita.core: BUG: The walker hasn't reached the root layer!
krita.core: Start node: KisPaintLayer(0xd8cd1c0, name = "Layer 6") Requested rect: QRect(0,0 512x512)
krita.core: There must be an inconsistency in the walkers happened!
krita.core: Please report a bug describing how you got this message.
krita.core: BUG: The walker hasn't reached the root layer!
krita.core: Start node: KisPaintLayer(0xd8cd1c0, name = "Layer 6") Requested rect: QRect(1024,0 512x512)
krita.core: There must be an inconsistency in the walkers happened!
krita.core: Please report a bug describing how you got this message.
krita.core: BUG: The walker hasn't reached the root layer!
krita.core: Start node: KisPaintLayer(0xd8cd1c0, name = "Layer 6") Requested rect: QRect(1536,0 512x512)
krita.core: There must be an inconsistency in the walkers happened!
krita.core: Please report a bug describing how you got this message.
krita.core: BUG: The walker hasn't reached the root layer!
krita.core: Start node: KisPaintLayer(0xd8cd1c0, name = "Layer 6") Requested rect: QRect(512,512 512x512)
krita.core: There must be an inconsistency in the walkers happened!
krita.core: Please report a bug describing how you got this message.
krita.core: BUG: The walker hasn't reached the root layer!
krita.core: Start node: KisPaintLayer(0xd8cd1c0, name = "Layer 6") Requested rect: QRect(512,0 512x512)
krita.core: BUG: The walker hasn't reached the root layer!
krita.core: There must be an inconsistency in the walkers happened!
krita.core: Start node: KisPaintLayer(0xd8cd1c0, name = "Layer 6") Requested rect: QRect(2048,0 432x512)
krita.core: There must be an inconsistency in the walkers happened!
krita.core: Please report a bug describing how you got this message.
krita.core: Please report a bug describing how you got this message.
krita.core: BUG: The walker hasn't reached the root layer!
krita.core: Start node: KisPaintLayer(0xd8cd1c0, name = "Layer 6") Requested rect: QRect(0,512 512x512)
krita.core: There must be an inconsistency in the walkers happened!
krita.core: Please report a bug describing how you got this message.
Eeek... This breaks converting colorspace: http://www.peppercarrot.com/extras/temp/2016-12-07_screenshot_142704_net.jpg
yes i got this dialog box too while testing, but it goes away after some time for me . i didn't try to convert color space though. it used to trigger when i painted a heavy stroke and did some layer operation.