Implement interactive window selection for Wayland platforms
ClosedPublic
Actions

Authored by graesslin on Nov 15 2016, 1:31 PM.

Details

Reviewers

Group Reviewers

Plasma on Wayland
KWin

Commits

R108:af56c6b050e9: Implement interactive window selection for Wayland platforms
R108:fd83366e31b9: Implement interactive window selection for Wayland platforms

Summary

The interactive window selection is implemented in InputRedirection
through a dedicated InputEventFilter. The InputEventFilter so far takes
care of pointer input and keyboard input. In addition it ensures that
keyboard and pointer focus is reset on start and on end.

With this change KillWindow now also works on Wayland, but only for X11
windows, as the Wayland variant is not yet implemented.

Test Plan

Tested in nested setup, auto-tests still needed

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 8160.Nov 15 2016, 1:31 PM

graesslin retitled this revision from to Implement interactive window selection for Wayland platforms.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma on Wayland.

Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptNov 15 2016, 1:31 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

graesslin added a dependency: D3363: Support interactive window selection through the Platform.Nov 15 2016, 1:31 PM

graesslin added a dependent revision: D3370: KillWindow support for Wayland windows.Nov 15 2016, 4:40 PM

broulik added a subscriber: broulik.Nov 15 2016, 7:00 PM

broulik added inline comments.

input.cpp
488	Can this happen? You check for buttons being NoButton and then for button being RightButton?
1409	Where is that being cleaned up?

graesslin added inline comments.Nov 16 2016, 6:28 AM

input.cpp
488	Yes of course. QMouseEvent::buttons contains the buttons currently hold. So we test that no buttons are currently pressed. And QMouseEvent::button contains the button which generated the event. So this tests that the right mouse button was released and no further button is hold.
1409	like all InputEventFilters in InputRedirection::~InputRedirection

sebas accepted this revision.Nov 16 2016, 4:21 PM

sebas added a reviewer: sebas.

This revision is now accepted and ready to land.Nov 16 2016, 4:21 PM

Closed by commit R108:fd83366e31b9: Implement interactive window selection for Wayland platforms (authored by graesslin). · Explain WhyNov 17 2016, 8:43 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		autotests/integration/CMakeLists.txt (1 line)
A	M	autotests/integration/window_selection_test.cpp (369 lines)
M		input.h (8 lines)
M		input.cpp (116 lines)
M		keyboard_input.h (2 lines)
M		keyboard_input.cpp (2 lines)
M		platform.h (3 lines)
M		platform.cpp (8 lines)
M		pointer_input.h (13 lines)
M		pointer_input.cpp (90 lines)
M		wayland_cursor_theme.h (1 line)
M		wayland_cursor_theme.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8160	0d45162		Nov 15 2016, 1:31 PM	★	★
Diff 2	8251	7b464cf	rKWINfd83366e31b9219cb6b74620fb7bf299deda4b45	Nov 17 2016, 8:42 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
9ee859327d1b	bcaab1ce080a	0d451620575a	Martin Gräßlin	Implement interactive window selection for Wayland platforms (Show More…)	Nov 15 2016, 1:23 PM

Status	Author	Revision
Closed	graesslin	D3367 [effects] Add interactive window selection mode to ScreenshotEffect
Closed	graesslin	D3370 KillWindow support for Wayland windows
Closed	graesslin	D3365 Implement interactive window selection for Wayland platforms
Closed	graesslin	D3363 Support interactive window selection through the Platform
Closed	graesslin	D3362 Port KillWindow to X11EventFilter
Closed	graesslin	D3361 Support multiple event types in X11EventFilter