[effects] Add interactive window selection mode to ScreenshotEffect
ClosedPublic
Actions

Authored by graesslin on Nov 15 2016, 2:42 PM.

Details

Reviewers

Group Reviewers

Plasma on Wayland
KWin

Commits

R108:27376e39ef85: [effects] Add interactive window selection mode to ScreenshotEffect

Summary

EffectsHandler gains a new method to startInteractiveWindowSelection
which just delegates to the one in Platform. That way a window can be
selected and returned to an Effect.

The screenshot effect makes use of this new functionality and provides
an interactive window screenshot mode which saves to a temporary file.
Note that this is not yet the variant intended for use in spectacle.

Test Plan

Took a screenshot on Wayland

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 8162.Nov 15 2016, 2:42 PM

graesslin retitled this revision from to [effects] Add interactive window selection mode to ScreenshotEffect.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma on Wayland.

Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptNov 15 2016, 2:42 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

graesslin added a dependency: D3363: Support interactive window selection through the Platform.Nov 15 2016, 2:43 PM

sebas accepted this revision.Nov 16 2016, 4:22 PM

sebas added a reviewer: sebas.

sebas added a subscriber: sebas.

sebas added inline comments.

effects/screenshot/screenshot.h
58	... a window to screenshot.

This revision is now accepted and ready to land.Nov 16 2016, 4:22 PM

Closed by commit R108:27376e39ef85: [effects] Add interactive window selection mode to ScreenshotEffect (authored by graesslin). · Explain WhyNov 17 2016, 1:07 PM

This revision was automatically updated to reflect the committed changes.

zzag mentioned this in D19552: [effects/screenshot] Set m_windowMode in screenshotWindowUnderCursor.Mar 5 2019, 9:55 PM

Revision Contents
Changeset List

			Path	Packages
M			autotests/mock_effectshandler.h (4 lines)
M			effects.h (2 lines)
M			effects.cpp (13 lines)
M			effects/screenshot/screenshot.h (16 lines)
M			effects/screenshot/screenshot.cpp (57 lines)
M			libkwineffects/kwineffects.h (16 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8162	0d45162		Nov 15 2016, 2:42 PM	★	★
Diff 2	8266	e5f02e8	rKWIN27376e39ef85672084a17e1eada1b49bb55c765a	Nov 17 2016, 1:06 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
10806f035158	af36567aeb69	0d451620575a	Martin Gräßlin	[effects] Add interactive window selection mode to ScreenshotEffect (Show More…)	Nov 15 2016, 2:40 PM

Status	Author	Revision
Closed	graesslin	D3370 KillWindow support for Wayland windows
Closed	graesslin	D3365 Implement interactive window selection for Wayland platforms
Closed	graesslin	D3367 [effects] Add interactive window selection mode to ScreenshotEffect
Closed	graesslin	D3363 Support interactive window selection through the Platform
Closed	graesslin	D3362 Port KillWindow to X11EventFilter
Closed	graesslin	D3361 Support multiple event types in X11EventFilter