Support multiple event types in X11EventFilter
ClosedPublic
Actions

Authored by graesslin on Nov 15 2016, 7:26 AM.

Details

Reviewers

Group Reviewers

Plasma
KWin

Commits

R108:9f976a4b8dd7: Support multiple event types in X11EventFilter

Summary

So far the X11EventFilter only supported one event type. But most
usecases for an X11EventFilter require to support multiple event types.
E.g. a filter listens for both key press and key release.

This change extends the internal X11EventFilter to support multiple
types and Workspace::workspaceEvent makes use of that.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 8147.Nov 15 2016, 7:26 AM

graesslin retitled this revision from to Support multiple event types in X11EventFilter.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma.

Restricted Application added a project: KWin. · View Herald TranscriptNov 15 2016, 7:26 AM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

rebased on master
fix a bug in new code (didn't register on Workspace)

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptNov 15 2016, 7:50 AM

graesslin added a dependent revision: D3362: Port KillWindow to X11EventFilter.Nov 15 2016, 8:59 AM

mart accepted this revision.Nov 15 2016, 10:42 AM

mart added a reviewer: mart.

This revision is now accepted and ready to land.Nov 15 2016, 10:42 AM

broulik added a subscriber: broulik.Nov 15 2016, 6:49 PM

broulik added inline comments.

x11eventfilter.cpp
58	m_eventTypes could be empty here, maybe add a Q_ASSERT in the QVector<int> constructor?

graesslin added inline comments.Nov 16 2016, 6:21 AM

x11eventfilter.cpp
58	no, it cannot be empty. just two lines above there is a check for m_eventTypes having exactly one element.

Closed by commit R108:9f976a4b8dd7: Support multiple event types in X11EventFilter (authored by graesslin). · Explain WhyNov 16 2016, 6:49 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/test_xrandr_screens.cpp (4 lines)
M			events.cpp (6 lines)
M			x11eventfilter.h (10 lines)
M			x11eventfilter.cpp (18 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8147	c0b2e5d		Nov 15 2016, 7:26 AM	★	★
Diff 2	8148	cef03c2	* rebased on master	Nov 15 2016, 7:50 AM	★	★
Diff 3	8193	730fd05	rKWIN9f976a4b8dd78b7b4312806b2f78c609879c3ea8	Nov 16 2016, 6:48 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
51f54ce783cc	9aaf261a66de	cef03c2b9e39	Martin Gräßlin	Support multiple event types in X11EventFilter (Show More…)	Nov 15 2016, 7:22 AM

Status	Author	Revision
Closed	graesslin	D3370 KillWindow support for Wayland windows
Closed	graesslin	D3365 Implement interactive window selection for Wayland platforms
Closed	graesslin	D3367 [effects] Add interactive window selection mode to ScreenshotEffect
Closed	graesslin	D3363 Support interactive window selection through the Platform
Closed	graesslin	D3362 Port KillWindow to X11EventFilter
Closed	graesslin	D3361 Support multiple event types in X11EventFilter