Support interactive window selection through the Platform
ClosedPublic

Authored by graesslin on Nov 15 2016, 9:44 AM.

Details

Summary

A new virtual method is added to Platform:
startInteractiveWindowSelection

The interactive window selection enters a mode where the user can select
a window through the pointer or keyboard device. The cursor is turned
into a crosshair cursor, unless another cursor name is provided (e.g.
pirate for kill window).

Once a window is selected the provided callback method is invoked with
the selected Toplevel as argument. In case the user cancelled the
selection a nullptr argument is passed in.

Currently it's only implemented by the X11 standalone platform using the
logic from KillWindow. Just instead of killing the window the callback
is invoked.

KillWindow loses the X11 implementation and interacts with the new
functionality in Platform by providing a lambda function for the
killing.

Test Plan

Killing of X11 windows is still possible

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 8150.Nov 15 2016, 9:44 AM
graesslin retitled this revision from to Support interactive window selection through the Platform.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin. · View Herald TranscriptNov 15 2016, 9:44 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
sebas accepted this revision.Nov 16 2016, 4:19 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Nov 16 2016, 4:19 PM
This revision was automatically updated to reflect the committed changes.