Added dialog for SVN Update, SVN Revert and SVN Commit actions.
This dialog is universal and prints everything from stdout and stderr (stderr prints in red).
Supports for "Cancel" action which sends terminate signal to a running process.
elvisangelaccio | |
meven |
Dolphin | |
VDG |
No Linters Available |
No Unit Test Coverage |
Buildable 27072 | |
Build 27090: arc lint + arc unit |
canceling svn process leaves a repository in inconsistent state: need to call 'svn cleanup' manually.
Make you plugin inform the user then ? Or automatically cleanup ? or Optionaly cleanup ?
svn/svnprogressdialog.cpp | ||
---|---|---|
112 | Shouldn't it be Accept then ? |
svn/svnprogressdialog.cpp | ||
---|---|---|
112 | This is the reject() signal, we are here in case user closes window (with Alt+F4, for example). Even if dialog successed we should reject() it as it is default behavior isn't it? |
svn/svncommands.h | ||
---|---|---|
158 | removeUnversioned, removeIgnored, bool includeExternals, are never used, maybe hook them to a UI checkbox ? confirmation dialog ? A settings ? |
svn/svncommands.h | ||
---|---|---|
158 | This parameters are about to be used in additional 'SVN Cleanup...' action. |
@elvisangelaccio Can I rename to buttonCancel/buttonOk instead of cancelButton/okButton? If variable name starts with UI element it's easier to use code completion.