Added dialog for SVN Update, SVN Revert and SVN Commit actions.
This dialog is universal and prints everything from stdout and stderr (stderr prints in red).
Supports for "Cancel" action which sends terminate signal to a running process.
Details
Details
- Reviewers
elvisangelaccio meven - Group Reviewers
Dolphin VDG - Commits
- R449:37b909f57f92: [svn] Added basic svn commands logging output.
Added dialog for SVN Update, SVN Revert and SVN Commit actions.
This dialog is universal and prints everything from stdout and stderr (stderr prints in red).
Supports for "Cancel" action which sends terminate signal to a running process.
- Try "SVN Commit", "SVN Revert" and "SVN Update" actions from plugin popup menu.
- Try "SVN Revert" action from "SVN Commit" dialog.
Diff Detail
Diff Detail
- Repository
- R449 Plugins for Dolphin
- Branch
- svn_update (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 26975 Build 26993: arc lint + arc unit
Comment Actions
canceling svn process leaves a repository in inconsistent state: need to call 'svn cleanup' manually.
Make you plugin inform the user then ? Or automatically cleanup ? or Optionaly cleanup ?
| svn/svnprogressdialog.cpp | ||
|---|---|---|
| 111 | Shouldn't it be Accept then ? | |
Comment Actions
- Update in response to review comments.
- Added new svn commands to cleanup and find repository working copy by a file.
- Added auto 'svn cleanup'.
- Fixed names, added comments.
| svn/svnprogressdialog.cpp | ||
|---|---|---|
| 111 | This is the reject() signal, we are here in case user closes window (with Alt+F4, for example). Even if dialog successed we should reject() it as it is default behavior isn't it? | |
| svn/svncommands.h | ||
|---|---|---|
| 149 | removeUnversioned, removeIgnored, bool includeExternals, are never used, maybe hook them to a UI checkbox ? confirmation dialog ? A settings ? | |
| svn/svncommands.h | ||
|---|---|---|
| 149 | This parameters are about to be used in additional 'SVN Cleanup...' action. | |
Comment Actions
@elvisangelaccio Can I rename to buttonCancel/buttonOk instead of cancelButton/okButton? If variable name starts with UI element it's easier to use code completion.