Add friendly ping-pong animation to allow visibility of full text
in an animated way
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Details
Details
- Reviewers
ognarb davidedmundson ngraham - Group Reviewers
Plasma VDG
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Branch
- ping_pong_text
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 26518 Build 26536: arc lint + arc unit
Comment Actions
You should include a video in the test plan since you're creating visual changes with motion.
Comment Actions
I'm not sure it is a good idea, but at least for me it break the clock in my panel.
Edit: in mp4
Comment Actions
Plasmacomponents is deprecated please see Plasmacomponents3 then see the readme within that and put this somewhere else.
- Label is a super super super common element we don't want to add any overhead instantiating a label. A new special class would be best
- It can all be done in one SequentialAnimation, you don't need states.
- You don't need to get the width again, we know this already from the other text properties.
- This is broken for any text that's wrapped or elided
Comment Actions
Thanks @davidedmundson and @ognarb, I was able to replicate the issue, I'll think a bit more in my approach
Comment Actions
I feel like this could break Labels unknowingly. Maybe it would make sense to have an extra scrollToFit (?) property or even another separate component to do that.
Seeing things bouncing without the author intending could be worse than having the text cut off.
Comment Actions
Yeah, This should be a new component, or at most enabled by an off-by-default property. The default behavior should not change.