Use qdbus for actions in desktop file
ClosedPublic

Authored by davidre on Feb 22 2019, 12:48 PM.

Details

Summary

As noted by @davidedmundson in D19153 Spectacle uses the spectacle command for the actions it defines in it's desktop file. This changes these
actions to use the same dbus commands as the actions defined in the khotkeys file. This opens the screenshot in the same instance of Spectacle
if it's running. Which is more expected than opening a new window if you right click on spectacle in the task manager and give it the command
"Take a new screenshot"

Test Plan
  • Open Spectacle
  • Right click on it in the task manager
  • No new window is opened, spectacle is now showing the new screenshot

Diff Detail

Repository
R166 Spectacle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidre created this revision.Feb 22 2019, 12:48 PM
Restricted Application added a project: Spectacle. · View Herald TranscriptFeb 22 2019, 12:48 PM
Restricted Application added a subscriber: Spectacle. · View Herald Transcript
davidre requested review of this revision.Feb 22 2019, 12:48 PM
davidre updated this revision to Diff 52295.Feb 22 2019, 12:51 PM

Fix missing slash

davidedmundson accepted this revision.Feb 22 2019, 1:19 PM
This revision is now accepted and ready to land.Feb 22 2019, 1:19 PM
ngraham accepted this revision.Feb 22 2019, 2:58 PM
This revision was automatically updated to reflect the committed changes.