| ngraham | |
| nicolasfella | |
| elvisangelaccio |
| Dolphin |
The binary packages(deb and rpm) can't be uninstalled like the other packages.
Before the installer would give an error message that the deinstallation failed,
now the error message contains information on what to do.
WIP: If you think that an option to run a deinstall command should be executed instead, I will implement it.
servicemenuinstaller uninstall somepackage.deb
| No Linters Available |
| No Unit Test Coverage |
| Buildable 25659 | |
| Build 25677: arc lint + arc unit |
| src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp | ||
|---|---|---|
| 276 | Why not show a KMessageBox? | |
| src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp | ||
|---|---|---|
| 276 | So far the messages have been show with kdialog, thats why I didn't wanted to mix that too much up in this patch. But there is an issue when opening the files for uninstalling by the mime type: | |
WIP: If you think that an option to run a deinstall command should be executed instead, I will implement it.
Yeah, telling the user how to fix it is a nice improvement for sure, but even better would be uninstalling automatically. If you have the package namer, you can use packagekit to uninstall it so you don't need to write code specific for apt, zypper, dnf, etc.
There's an example of how to do this in the kdenetwork-filesharing repo, where we use PackageKit to install samba packages at the user's request.
This is reminding me that I need to finish up my patch to make Konsole installable via PackageKit if you open the terminal panel when it's not installed.
This sounds interesting, is it also possible to install local packages?
In that case the install process could be improved, because we actually know if the user installed the package or aborted.
I am also not sure on which branch this should go. It would make sense to me to
land this on 20.04.1, but then introducing new dependencies seems like a bad idea^^.
Yup, PackageKit can do that.
I am also not sure on which branch this should go. It would make sense to me to
land this on 20.04.1, but then introducing new dependencies seems like a bad idea^^.
Since this patch includes a new string, if landed in its current form, it would have to be the master branch. String changes can only be made on master. Same with dependency changes, obviously. :)
Should I make the PackageKit integration in a new patch where I also refactor the install method?
And in that case should I abandon this patch?