Updates VCS-plugins for the new KVersionControlPlugin interface. Updates available in the separate commit D29041.
Plugins unversionedActions() functions now do nothing so it doesn't change any current plugin behaviour.
Details
Details
- Reviewers
meven elvisangelaccio - Group Reviewers
Dolphin - Commits
- R449:b0717f10702f: Updates in response to KVersionControlPlugin interface changes.
Diff Detail
Diff Detail
- Repository
- R449 Plugins for Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Git, mercurial and bazar can do things to unversionned files : add them to their index.
I am not sure if that is a regression though or if you can still add files.
Not sure about dropbox.
Comment Actions
Apparently not, unversionedActions is an unfortunate name for those plugins as unversionned has a different meaning and got me confused.
Comment Actions
Please don't "BUG: 420239" as it is not actually fixing it yet and assume the checkout/clone actions will come in a subsequent differential revision.
And use "FEATURE: 420239" since this will be a new feature.
Comment Actions
Your changes are all good ;)
But you can't FEATURE: 420239 since the feature is not implemented here, (at least as of now).
Please run arc amend on your local branch to remove it from the commit message.
| bazaar/fileviewbazaarplugin.cpp | ||
|---|---|---|
| 277 | Semicolon not necessary. Same for all other Q_UNUSED below. | |
Comment Actions
Yes ;)
When @elvisangelaccio approved with a small comment, he meant fix those small things and GTM.