This commit changes VCS-plugin interface in order to provide actions for unversioned items (for example clone or checkout repository), updates to dolphin-plugins comes in the separate commit D29042.
Details
Details
- Reviewers
meven elvisangelaccio - Group Reviewers
Dolphin - Commits
- R318:67a5ec53ef5a: For VCS-plugin interface added pure virtual function outOfVersionControlActions…
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/views/versioncontrol/kversioncontrolplugin.h | ||
|---|---|---|
| 189 | Perhaps use "notVersioned" as it is confusing with DVCS that have a notion of unversioned files and folders with a different meaning. | |
Comment Actions
@meven
I am agree this names might be confusing.
Let's figure out more appropriate names for functions: if we will accept revision this would be for long, lets make it clear.
What do you say about 'actions()' (as it was) and 'additionalActions()' (for any additional actions outside versioned directory, we will mark it in the documentation: the function name itself will be not very meaningful though)?
Comment Actions
Not convinced additionalActions supposed there were already some actions in the first place.
How about outOfVersionControlActions ?
Comment Actions
FEATURE: 420239 should only be added the diff actually implementing the features (so the changelog only references the same features once), here the one adding clone/checkout actions.
Here it is just a dependency for the future feature.
The other diffs can only reference the bug with CCBUG: 420239 in the meantime.
But you don't have to add it though.
Comment Actions
All is nice.
Just naming is hard and I'd like to keep it the least confusing possible.
I hope this is not annoying for you.
| src/views/versioncontrol/kversioncontrolplugin.h | ||
|---|---|---|
| 183–184 | Maybe "items in a version controlled path" instead of "versioned items", since this includes unversionned files in git repos for instance. | |
| 186–193 | Maybe versionControlActions should be clearer. | |
| src/views/versioncontrol/versioncontrolobserver.cpp | ||
| 125–133 | isVersioned could be renamed isVersionControlled | |
Comment Actions
- Name change: versionedActions() -> versionControlActions()
- Name change: isVersioned() -> isVersionControlled()
- Added comment changes in response to review comments
Comment Actions
It's absolutely fine, I really appreciate your help! Thanks for your time on this one.
I think this is a necessary changes so another thanks for good ideas.
| src/views/versioncontrol/versioncontrolobserver.cpp | ||
|---|---|---|
| 129 | Please call this variable plugin. | |
| src/views/versioncontrol/versioncontrolobserver.cpp | ||
|---|---|---|
| 129 | You misunderstood: it is i that should be named plugin since it comes from a m_plugins variable. | |