Differential D28836

Dolphin Service Installer: Run uninstall scripts, rename methods
ClosedPublic
Actions

Authored by alex on Apr 14 2020, 5:53 PM.

Details

Reviewers
ngraham
nicolasfella
elvisangelaccio
Group Reviewers
Dolphin
Commits
R318:5bbdf66fce8d: Dolphin Service Installer: Run uninstall scripts, rename methods
Summary

Now scripts starting with uninstall are being executed.
Addtionally the runInstallerScriptOnce method has been renamed, because it is used to run the install/uninstall scripts.
Same for runInstallerScript.
Depends on D28801

Test Plan

Compile, run tests. Try to uninstall a dolphin service which has a uninstall.sh script.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alex created this revision.Apr 14 2020, 5:53 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptApr 14 2020, 5:53 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
alex requested review of this revision.Apr 14 2020, 5:53 PM
elvisangelaccio accepted this revision.Apr 14 2020, 10:13 PM
This revision is now accepted and ready to land.Apr 14 2020, 10:13 PM
alex added a comment.Apr 15 2020, 4:20 AM

This should also go to release/20.04 is that ok?

elvisangelaccio added a comment.Apr 20 2020, 10:16 PM
In D28836#648673, @alex wrote:

This should also go to release/20.04 is that ok?

Yes, please do it before april 16th.

cfeck added a subscriber: cfeck.Apr 21 2020, 5:04 AM

20.04 tars are already up. Would this fix a bug that is worth doing a respin?

alex added a comment.Apr 21 2020, 6:30 AM

Nope, this is not worth a respin. Then I will land this on master.

ngraham added a comment.Apr 21 2020, 4:23 PM

You can land on the stable branch anyway and it will wind up in 20.04.1

Closed by commit R318:5bbdf66fce8d: Dolphin Service Installer: Run uninstall scripts, rename methods (authored by alex). · Explain WhyApr 21 2020, 7:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 80803

View Options

src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp

Loading...