fix(kcm): show output ids in reference to currently applied config
ClosedPublic

Authored by bport on Apr 14 2020, 10:58 AM.

Details

Summary

Currently output identification uses the pending configuration to position
output ids. That can result in output ids being inverted (if you move screen
for example).

In order to fix that, we instead use the applied configuration to identify
outputs.

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bport created this revision.Apr 14 2020, 10:58 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 14 2020, 10:58 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bport requested review of this revision.Apr 14 2020, 10:58 AM

Seems very sensible. +1

Note that kscreen has a commit message schema different to every other KDE policy. See CONTRIBUTING.md at the root level.

bport updated this revision to Diff 80086.Apr 14 2020, 11:20 AM

update commit message

romangg requested changes to this revision.Apr 14 2020, 1:06 PM
romangg removed reviewers: meven, ervin.
romangg added a subscriber: romangg.

Message guideline must be adhered. Summary must be more extensive.

This revision now requires changes to proceed.Apr 14 2020, 1:06 PM
bport retitled this revision from Identify output according to current applied position, not an unapplied position to fix(kcm): Identify output according to current applied position, not an unapplied position.Apr 14 2020, 1:41 PM
bport edited the summary of this revision. (Show Details)

Header subject and commit message body must have shorter line length in line with message guideline. Also note regarding capitalization Angular's subject guideline.

Also the current description sucks. That's a single sentence with way too many words and no grammar.

Come on, coding is not only about the code. Be proud of your work and present it to us in the way that it deserves.

Also my assumption is you work together with the original reviewers in the same company and may have discussed this patch internally already. That's fine but note that this project and any other KDE project is not owned by your company alone and it's your responsibility in the end to transform your internal discussions and the knowledge you gained from that into public knowledge available to all members of this community.

That's why a good description, and in the end all of the documentation you do when coding, is tremendously important.

bport retitled this revision from fix(kcm): Identify output according to current applied position, not an unapplied position to fix(kcm): show screen identification in the good screen.Apr 14 2020, 2:20 PM
bport edited the summary of this revision. (Show Details)
romangg retitled this revision from fix(kcm): show screen identification in the good screen to fix(kcm): show output ids in reference to currently applied config.Apr 14 2020, 2:29 PM
romangg edited the summary of this revision. (Show Details)
romangg accepted this revision.Apr 14 2020, 2:32 PM

I changed up the description a bit more (line length!). Please make sure to push with arc so it fetches this description for the commit message.

Code change makes sense. Thanks for the fix.

This revision is now accepted and ready to land.Apr 14 2020, 2:32 PM
This revision was automatically updated to reflect the committed changes.