BUG: 397493
Details
Details
- Reviewers
sars ngraham - Group Reviewers
KDE Applications - Commits
- R483:3f02d27dd9ce: Remove unnecessary overwrite prompt
Diff Detail
Diff Detail
- Repository
- R483 Skanlite
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
All unit tests (i.e. one) passed, and I have tested this on all save-as cases I can think of. Thank you for reviewing this patch!
Comment Actions
- I'd remove the comment about the removed dialog, as it looks odd when looking at the code without checking the history
- the statJob is now useless, just drop it
Comment Actions
Thanks!
Sorry for the faaaar to late response...
I was not sure if this would break the remote protocols (fish/sftp/..), but I just tried it and this patch improves the code thanks!
Please commit! (there where some trailing spaces that you could remove)
off topic:
While testing I found that there is a bug with the remote protocols that the URL is saved wrongly and is broken when you reopen the save dialog...
Comment Actions
Unified changes
Reset previous commits due to incorrect git config, then unified them into a single commit.
Also stripped out the trailing whitespace.
Comment Actions
Do you have commit rights? If not, please state if the committer's mail address should be the same you used in the bug report, or otherwise state a different address.
Comment Actions
No, I do not have commit rights. I actually changed the email on bugzilla recently (but not on phabricator as it seemed impossible to do so w/o sysadmin's manual intervention), so to avoid confusion, it's fkfd@macaw.me. The name should be "Frederick Yin". Thanks!
Comment Actions
Also @sars, I notice that Skanlite hasn't gotten a release in a while. I wonder if it would be beneficial to move it to the release service so that it can share the same release schedule as most KDE apps and automatically get three major releases per year, with three minor releases per major one. What do you think?
Comment Actions
Yes please. I do the releases so seldom that I always have to learn again how to do the releases, so then I hesitate to start the release process...
Comment Actions
If you go the release service route, can you please wait for the gitlab migration, which should happen soon (two weeks iirc, and way before the cut date for the list of packages in RS 20.08?)
Comment Actions
@ltoscano Yes sure, I have not made a release in over two years :( so waiting a bit more should not be a problem ;)
I should make a manual release soon tho, there is so much new stuff that has been added...