Depends on D28033
Details
- Reviewers
broulik - Group Reviewers
VDG Plasma - Maniphest Tasks
- T12812: Create re-usable Plasma Component for expandable list item and port applets to use it
The only major UI change is the loss of the progress bar. It is replaced with a textual
display of free space and total space in the subtitle, which is more consistent with the
appearance of other ExpandableListItem-using applets, and IMO is more useful anyway.
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- port-to-ExpandableListItem (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 26555 Build 26573: arc lint + arc unit
applets/devicenotifier/package/contents/ui/DeviceItem.qml | ||
---|---|---|
32 | There's an expandedDevice property in devicenotifier.qml which is supposed to decide which device is expanded. You either want to wire up this properly with the new delegate or nuke it. Connections { target: devicenotifier onExpandedDeviceChanged: { if (devicenotifier.expandedDevice === udi) { deviceItem.expand(); } else { deviceItem.collapse(); } } } However, it resets the expandedDevice right away for whatever reason. But this should maybe give you an idea. Alternatively, since expanded state is now in the delegate, you could just emit a signal when a source is added to have the device expand. | |
34 | This is all over the place for me. All the free space jobs in the dataengine get the root size back. Not sure if a local issue or KIO? @dfaure |
applets/devicenotifier/package/contents/ui/DeviceItem.qml | ||
---|---|---|
34 | Please give me a proper bug report in KIO terms :-) I don't see a bug in a TODO comment in some QML code ;) |
Remove more FIXMEs (the first one was already broken with the current implementation), and for the second one, there's no better way to implement this, though I may remove the logic entirely
Remove a FIXME (it's already a problem in the existing version so it's not an artifact of this port
I'd like to land this early in the 5.20 cycle so we have lots of time for testing, if possible.
Cleaned this up a bit and moved it to https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/151