Differential D28191

[KFontChooser] General code cleanup
ClosedPublic
Actions

Authored by ahmadsamir on Mar 21 2020, 7:16 PM.

Details

Reviewers
cfeck
apol
bport
dfaure
Group Reviewers
Frameworks
Commits
R236:f22c1864f5c8: [KFontChooser] General code cleanup
Summary
  • Use new connect syntax
  • Prefix increment where appropriate
  • Replace foreach/iterator-based for with range-for
  • Remove (really) old TODOs
Test Plan

make && ctest
KFontChooser in e.g. Kate still loads and works as before

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Mar 21 2020, 7:16 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 21 2020, 7:16 PM
ahmadsamir requested review of this revision.Mar 21 2020, 7:16 PM
ahmadsamir updated this revision to Diff 78265.Mar 23 2020, 4:29 AM
ahmadsamir added a reviewer: dfaure.

Rebase

ahmadsamir updated this revision to Diff 78295.Mar 23 2020, 5:10 PM

Make connect() actually work for the QCheckBoxes

ahmadsamir updated this revision to Diff 78299.Mar 23 2020, 5:26 PM

Also enable size spinbox when enabling the size list box

ahmadsamir updated this revision to Diff 78375.Mar 24 2020, 4:16 PM
ahmadsamir edited the summary of this revision. (Show Details)
ahmadsamir edited the test plan for this revision. (Show Details)

Tweak

ahmadsamir updated this revision to Diff 78376.Mar 24 2020, 4:18 PM
ahmadsamir edited the summary of this revision. (Show Details)
ahmadsamir edited the test plan for this revision. (Show Details)

Fix, arcanist is....

dfaure accepted this revision.Mar 24 2020, 4:54 PM
This revision is now accepted and ready to land.Mar 24 2020, 4:54 PM
Closed by commit R236:f22c1864f5c8: [KFontChooser] General code cleanup (authored by ahmadsamir). · Explain WhyMar 24 2020, 5:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kfontchooser.h (1 line)
Msrc/kfontchooser.cpp (90 lines)

Diff 78382

View Options

src/kfontchooser.h

Loading...
View Options

src/kfontchooser.cpp

Loading...