Use breeze icons for categories
ClosedPublic

Authored by guoyunhe on Sat, Mar 7, 3:43 PM.

Details

Summary

Before:


After:

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
guoyunhe created this revision.Sat, Mar 7, 3:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSat, Mar 7, 3:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
guoyunhe requested review of this revision.Sat, Mar 7, 3:43 PM
guoyunhe edited the summary of this revision. (Show Details)Sat, Mar 7, 3:47 PM
guoyunhe added a reviewer: Plasma.
guoyunhe updated this revision to Diff 77174.Sat, Mar 7, 3:54 PM

Change object-group to object

davidre added a subscriber: davidre.Sat, Mar 7, 4:10 PM

There is something wrong on your system, this is how before looks for me:

There is something wrong on your system, this is how before looks for me:

Please ignore the content. I only want to compare the left panel.

There is something wrong on your system, this is how before looks for me:

Please ignore the content. I only want to compare the left panel.

Yes there is still a difference in the left panel in my screenshot compared to your before screenshot. Not pixelated and all categories colorful

guoyunhe edited the summary of this revision. (Show Details)Sat, Mar 7, 4:13 PM

There is something wrong on your system, this is how before looks for me:

Please ignore the content. I only want to compare the left panel.

Yes there is still a difference in the left panel in my screenshot compared to your before screenshot. Not pixelated and all categories colorful

The "pixelated" icon only appears to HiDPI display. The "monochrome" icon only appears when the system has dejavu-fonts installed. It looks different in different distros.

ngraham added a reviewer: apol.Sun, Mar 8, 3:48 PM
ngraham added a subscriber: ngraham.

Hmm, your before and after screenshots look identical to me.

What's the reason for this? To make them look better in High DPI mode? I thought that was already fixed with D27515: Icon: fix rendering of image: urls on High DPI

apol accepted this revision.Tue, Mar 10, 12:15 AM

Don't land before D27913.

This revision is now accepted and ready to land.Tue, Mar 10, 12:15 AM
Closed by commit R119:7a6e8f3bc52a: Use breeze icons for categories (authored by Guo Yunhe <i@guoyunhe.me>). · Explain WhyWed, Mar 11, 8:36 AM
This revision was automatically updated to reflect the committed changes.